Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named side effects #282

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Named side effects #282

merged 3 commits into from
Apr 16, 2024

Conversation

slinkydeveloper
Copy link
Contributor

Support for named side effects

….98bd326c

98bd326c Entry names + specify the entry that caused the failure in ErrorMessage (#86)
c47e65b0 Describe x-restate-user-agent (#85)
d43de04c Describe side effects in protocol (#84)
29b28f98 Modify Input/Output schema in deployment_manifest_schema.json (#80)
26d91e69 Replace protocol Empty message with custom one, so we remove the dependency on protobuf built-in messages (#79)
61ae44b2 Update documentation on error codes (#77)
576a1b26 Add HandlerType. Fix #1092 (#76)
0624d092 Payload schema for input and output. This provides basic format awareness. (#74)

git-subtree-dir: sdk-core/src/main/service-protocol
git-subtree-split: 98bd326c23f060d962821bca982bbb881e32c540
Copy link
Contributor

github-actions bot commented Apr 16, 2024

Test Results

 95 files  ±0   95 suites  ±0   7m 56s ⏱️ - 4m 23s
 82 tests ±0   80 ✅ ±0  2 💤 ±0  0 ❌ ±0 
212 runs  ±0  206 ✅ ±0  6 💤 ±0  0 ❌ ±0 

Results for commit 4657365. ± Comparison against base commit 0c5917b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Unit Test Results

  45 files  ±  0    45 suites  ±0   7m 23s ⏱️ + 3m 26s
637 tests +11  622 ✔️ +5  9 💤 ±0  6 +6 
637 runs  +10  622 ✔️ +4  9 💤 ±0  6 +6 

For more details on these failures, see this check.

Results for commit 48d511c. ± Comparison against base commit 0c5917b.

This commit adds support in the state machine to propagate additional entry info about "failing entries" in the EndMessage, and allows the user to set the name for side effect entries.
@slinkydeveloper slinkydeveloper merged commit 4657365 into main Apr 16, 2024
5 checks passed
@slinkydeveloper slinkydeveloper deleted the named-side-effects branch April 16, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant