Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement request identity #297

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Implement request identity #297

merged 6 commits into from
Apr 29, 2024

Conversation

slinkydeveloper
Copy link
Contributor

Fix #278

Copy link
Contributor

github-actions bot commented Apr 24, 2024

Test Results

 46 files  +1   46 suites  +1   2m 43s ⏱️ +9s
641 tests ±0  632 ✅ ±0  9 💤 ±0  0 ❌ ±0 
642 runs  +1  633 ✅ +1  9 💤 ±0  0 ❌ ±0 

Results for commit 91df1fb. ± Comparison against base commit 9718851.

This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both.
dev.restate.sdk.common.CoreSerdesTest ‑ Byte: 105
dev.restate.sdk.common.CoreSerdesTest ‑ Double: 0.07072016453844021
dev.restate.sdk.common.CoreSerdesTest ‑ Float: 0.05527097
dev.restate.sdk.common.CoreSerdesTest ‑ Integer: -983196108
dev.restate.sdk.common.CoreSerdesTest ‑ Long: 7013535649422325739
dev.restate.sdk.common.CoreSerdesTest ‑ Short: -25468
dev.restate.sdk.common.CoreSerdesTest ‑ byte[]: [B@68044f4
dev.restate.sdk.serde.jackson.JacksonSerdesTest ‑ [Till, Francesco]
RestateRequestIdentityVerifierTest ‑ parseKey()
dev.restate.sdk.common.CoreSerdesTest ‑ Byte: 98
dev.restate.sdk.common.CoreSerdesTest ‑ Double: 0.28447023151784057
dev.restate.sdk.common.CoreSerdesTest ‑ Float: 0.57615143
dev.restate.sdk.common.CoreSerdesTest ‑ Integer: -1668576129
dev.restate.sdk.common.CoreSerdesTest ‑ Long: -5310028650171459088
dev.restate.sdk.common.CoreSerdesTest ‑ Short: 2564
dev.restate.sdk.common.CoreSerdesTest ‑ byte[]: [B@256f8274

♻️ This comment has been updated with latest results.

Copy link
Contributor

@jackkleeman jackkleeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no Java expert but the implementation looks correct to me! Thank you

@slinkydeveloper slinkydeveloper merged commit 7b4dd3f into main Apr 29, 2024
4 checks passed
@slinkydeveloper slinkydeveloper deleted the issues/278 branch April 29, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement v1 request identity
2 participants