Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private methods made protected so they can be extended #32

Closed
wants to merge 1 commit into from
Closed

Private methods made protected so they can be extended #32

wants to merge 1 commit into from

Conversation

bkuhl
Copy link
Contributor

@bkuhl bkuhl commented Jan 24, 2018

Currently it's not possible to extend DiscordClient and overwrite the constructor without copying all of these private methods and nearly the whole class. making these protected allows it to be more extendable.

@bkuhl
Copy link
Contributor Author

bkuhl commented Jan 24, 2018

I was able to work around this problem, but in a bit of a sloppy manner since there's no way to detect if you're being rated limited by looking at the http status code of $this->discord->channel->createMessage($requestData);. You have to look at the response body.

@bkuhl bkuhl closed this Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant