Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RESTEASY-3490] Client proxy: invoke default methods rather than failing with RESTEASY004530 #4119

Conversation

stevenschlansker
Copy link
Contributor

Hi RESTEasy devs,

We use the client proxy. When calling a default method, we get an error RESTEASY004530 that the method isn't recognized.

Is it possible to extend the proxy implementation to respect default methods?

@jamezp
Copy link
Contributor

jamezp commented Apr 1, 2024

Hello @stevenschlansker. Yes, this is very reasonable and I honestly thought we were already doing it as I could have sworn it came up before. I'll review this as soon as I can.

@stevenschlansker
Copy link
Contributor Author

Thank you very much! Please let me know of any necessary updates I should make :)

@stevenschlansker
Copy link
Contributor Author

I looked into the test failures, and they don't seem related to my change:

 [INFO] Running org.jboss.resteasy.test.AsyncIOTest
Error:  Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.690 s <<< FAILURE! -- in org.jboss.resteasy.test.AsyncIOTest
Error:  org.jboss.resteasy.test.AsyncIOTest.testAsyncIo -- Time elapsed: 3.170 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <OK> but was: <KO>
	at org.jboss.resteasy.test.AsyncIOTest.testAsyncIo(AsyncIOTest.java:65)

@jamezp
Copy link
Contributor

jamezp commented Apr 3, 2024

Yes, those are not related. I've never been able to figure out what the issue is there. At some point it should be prioritized :) But nothing for you to worry about.

Copy link
Contributor

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think overall this looks good and makes sense. We will need to do a security manager check and likely handle some issues there. I can do this in a follow up PR though.

@jamezp jamezp changed the title Client proxy: invoke default methods rather than failing with RESTEASY004530 [RESTEASY-3490] Client proxy: invoke default methods rather than failing with RESTEASY004530 Apr 4, 2024
@stevenschlansker
Copy link
Contributor Author

Yes, I agree there will likely be followup changes, also JPMS can cause issues too. But since it 100% doesn't work now it isn't a regression :)

@jamezp
Copy link
Contributor

jamezp commented Apr 4, 2024

Yes, I agree there will likely be followup changes, also JPMS can cause issues too. But since it 100% doesn't work now it isn't a regression :)

Yes and technically it's not in a JPMS module anyway. We'll have a lot to solve to make that happen :)

@stevenschlansker
Copy link
Contributor Author

Closed in favor of #4125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants