Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook from editing a visitors post maps to FallBackChangeValue #749

Closed
zpalmai opened this issue Jun 30, 2017 · 3 comments
Closed

Webhook from editing a visitors post maps to FallBackChangeValue #749

zpalmai opened this issue Jun 30, 2017 · 3 comments
Assignees
Milestone

Comments

@zpalmai
Copy link
Contributor

zpalmai commented Jun 30, 2017

If you edit a visitors post and map the webhook event to a restfb class, it generates a FallBackChangeValue. The webhook looks like this:

{
   "entry":[
      {
         "changes":[
            {
               "field":"feed",
               "value":{
                  "verb":"edit",
                  "item":"post",
                  "sender_name":"Zsolt P\u00e1lmai",
                  "sender_id":10210043681558627,
                  "post_id":"753215778164799_819185084901201",
                  "recipient_id":753215778164799,
                  "created_time":1498831642,
                  "message":"test 111 4"
               }
            }
         ],
         "id":"753215778164799",
         "time":1498831680
      }
   ],
   "object":"page"
}

The problem is that the verb is usually "edited" for a regular post edit but in this case it's just simply "edit". The solution is simple: add "FEED_POST_EDIT(FeedPostValue.class)" to ChangeValueFactory.
The questions is if it should be fixed here or is it a facebook bug...

@nbartels nbartels added this to the 1.43.0 milestone Jun 30, 2017
@nbartels nbartels self-assigned this Jun 30, 2017
nbartels added a commit that referenced this issue Jun 30, 2017
nbartels added a commit that referenced this issue Jun 30, 2017
@nbartels
Copy link
Contributor

nbartels commented Jul 2, 2017

Regarding the inconsistency between EDIT and EDITED, I'll check the FB bugs and open a new one, if there is nothing. Thanks for the hint.

@scraly
Copy link

scraly commented Jul 2, 2017 via email

@nbartels
Copy link
Contributor

nbartels commented Jul 4, 2017

To point readers to the bug on the Facebook bugs platform:
https://developers.facebook.com/bugs/1819568831604696/

@restfb restfb locked and limited conversation to collaborators May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants