Warn if backup failed to read tree blob #2978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
force-pushed
the
warn-tree-error
branch
from
f314e0b
to
fb4951c
Compare
greatroar
reviewed
Oct 5, 2020
MichaelEischer
force-pushed
the
warn-tree-error
branch
from
fb4951c
to
dcbcb42
Compare
MichaelEischer
force-pushed
the
warn-tree-error
branch
from
dcbcb42
to
50da20d
Compare
MichaelEischer
added
the
category: resilience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
When
backupuses a parent snapshot it has to load the tree blobs of that snapshot. Previously a load failure was silently ignored, although a such a failure to load a tree blob indicates repository damage. This PR adds the missing warning message. Depending on whether the tree blob is contained in the index the warning message is eithertree 01234567 could not be loaded; the repository could be damaged: <error from backend>ortree 01234567 is not known; the repository could be damaged, runrebuild-indexto try to repair it.Was the change discussed in an issue or in the forum before?
No that I know.
Checklist
[ ] I have added documentation for the changes (in the manual)changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits