Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't hang when copy uses a single connection #3898

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

MichaelEischer
Copy link
Member

What does this PR change? What problem does it solve?

The copy command hangs when the source repository only uses a single backend connection. This is caused by reserving one connection for uploading, which is necessary to prevent deadlock for the prune command. However, copy uses different repositories, so there is reason to reserve a connection.

Was the change previously discussed in an issue or on the forum?

Fixes #3897

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • [ ] I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

@MichaelEischer MichaelEischer merged commit 3e70bac into restic:master Aug 30, 2022
@MichaelEischer MichaelEischer deleted the fix-copy-hang branch August 30, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restic copy -o local.connections=1 stuck forever.
1 participant