Add support for extended attributes on symlinks #4379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux allows the use of non-`user.` extended attributes on symlinks. One of the main users of this functionality is SELinux's `security.selinux` xattr for storing a path's label. By storing symlink xattrs, restic is now suitable for backing up the root filesystem on Linux distributions that use SELinux. This commit adds support for symlink xattrs when backing up data, restoring data, and mounting snapshots via a fuse mount. All calls to the xattr library have been updated to the use `L` variants of the various functions, which always operate on the path given, without following symlinks. Fixes: #4375 Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
|
LGTM. Looks like we previously backed up the wrong xattrs for symlinks (the ones for the target file). |
MichaelEischer
approved these changes
Jul 8, 2023
There was a problem hiding this comment.
LGTM. I've added amount of test coverage for extended attributes. The tests in restic/node only use files/dirs+xattrs as we can't write arbitrary xattrs for symlinks. Thus the tests somewhat miss the point, but should be close enough to ensure that this works.
Regarding other operating systems except for Windows, Linux and macOS we'll just have to wait and see whether this change causes problems.
|
Thank you! |
|
Looks like I've been to quick in merging the PR, #4401 fixes the windows build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Linux allows the use of non-
user.extended attributes on symlinks. One of the main users of this functionality is SELinux'ssecurity.selinuxxattr for storing a path's label. By storing symlink xattrs, restic is now suitable for backing up the root filesystem on Linux distributions that use SELinux.This commit adds support for symlink xattrs when backing up data, restoring data, and mounting snapshots via a fuse mount. All calls to the xattr library have been updated to the use
Lvariants of the various functions, which always operate on the path given, without following symlinks.Was the change previously discussed in an issue or on the forum?
Fixes: #4375
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.