Implement --insecure-no-password option.
#4808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelEischer
force-pushed
the
insecure-no-password
branch
from
27ee44a
to
ca07999
Compare
MichaelEischer
force-pushed
the
insecure-no-password
branch
from
ca07999
to
498cae5
Compare
|
nice idea, I hope it will be merged soon! |
The current pattern of using a global options variable is problematic.
This also includes two derived options `--from-insecure-no-password` used for commands that require specifying a source repository. And `--new-insecure-no-password` for the `key add` and `key passwd` commands. Specifying `--insecure-no-password` disabled the password prompt and immediately uses an empty password. Passing a password via CLI option or environment variable at the same time is an error.
MichaelEischer
force-pushed
the
insecure-no-password
branch
from
498cae5
to
1305062
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Implement #4326 (comment) . Different from that comment,
there are two additional options
--from-insecure-no-passwordand--new-insecure-no-password.--from-insecure-no-passwordis used for commands that require specifying a source repository, and--new-insecure-no-passwordfor thekey addandkey passwdcommands.Those options are required to allow copying from a repository without password to one with a password. Or the add/set an new empty password.
Was the change previously discussed in an issue or on the forum?
Fixes #1786
Fixes #4326
Replaces https://github.com/restic/restic/pull/4698/files
Checklist
changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.