-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export the bunyan serializers #65
Comments
trentm
added a commit
to trentm/clients
that referenced
this issue
Jun 27, 2016
…serializers Fixes restify#65 Fixes the regression from restify/node-restify#501
trentm
added a commit
to trentm/clients
that referenced
this issue
Jun 28, 2016
…serializers Fixes restify#65 Fixes the regression from restify/node-restify#501
trentm
added a commit
that referenced
this issue
Jun 28, 2016
…serializers (#66) Fixes #65 Fixes the regression from restify/node-restify#501
trentm
added a commit
to trentm/clients
that referenced
this issue
Oct 5, 2016
see #80 to correct a mistake made in this commit |
trentm
added a commit
that referenced
this issue
Oct 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Before restify-clients was split from restify, one would get access to Restify's Bunyan reserializers (especially its
client_req
andclient_res
serializers) via:This is required to create a Bunyan logger for restify clients so that you don't get big garbage in trace-level logs when
client_req
and/orclient_res
is logged (e.g. here:clients/lib/HttpClient.js
Line 314 in 8765244
There is some history and subtlety here:
clients/lib/HttpClient.js
Lines 401 to 405 in 8765244
However, even if that case is fixed (I'll try to do a PR for that), I think it would be good citizenship for restify-clients to export
.bunyan.serializers
for users that want to control their Bunyan logger serializers carefully. I'd be careful to NOT export theRequestCaptureStream
class that was carried over from restify (the server) itself because it isn't used or needed in the client.The text was updated successfully, but these errors were encountered: