Ignore exceptions parsing response cookies (#2015)

Co-authored-by: Francesc Castells <francesc.castells@sermo.com>
restsharp · Mar 4, 2023 · 1d289f9 · 1d289f9
1 parent 3a9fe6d
commit 1d289f9
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 1 deletion.
diff --git a/src/RestSharp/RestClient.Async.cs b/src/RestSharp/RestClient.Async.cs
@@ -119,7 +119,12 @@ public partial class RestClient {
             // Parse all the cookies from the response and update the cookie jar with cookies
             if (responseMessage.Headers.TryGetValues(KnownHeaders.SetCookie, out var cookiesHeader)) {
                 foreach (var header in cookiesHeader) {
-                    cookieContainer.SetCookies(url, header);
+                    try {
+                        cookieContainer.SetCookies(url, header);
+                    }
+                    catch (CookieException) {
+                        // Do not fail request if we cannot parse a cookie
+                    }
                 }
             }
 

diff --git a/test/RestSharp.Tests.Integrated/CookieTests.cs b/test/RestSharp.Tests.Integrated/CookieTests.cs
@@ -48,4 +48,21 @@ public class CookieTests {
             c.HttpOnly.Should().Be(httpOnly);
         }
     }
+
+    [Fact]
+    public async Task GET_Async_With_Response_Cookies_Should_Not_Fail_With_Cookie_With_Empty_Domain() {
+        var request  = new RestRequest("set-cookies");
+        var response = await _client.ExecuteAsync(request);
+        response.Content.Should().Be("success");
+
+        Cookie? notFoundCookie = FindCookie("cookie_empty_domain");
+        notFoundCookie.Should().BeNull();
+
+        HeaderParameter? emptyDomainCookieHeader = response.Headers!
+            .SingleOrDefault(h => h.Name == KnownHeaders.SetCookie && ((string)h.Value!).StartsWith("cookie_empty_domain"));
+        emptyDomainCookieHeader.Should().NotBeNull();
+        ((string)emptyDomainCookieHeader!.Value!).Should().Contain("domain=;");
+
+        Cookie? FindCookie(string name) => response!.Cookies!.FirstOrDefault(p => p.Name == name);
+    }
 }
diff --git a/test/RestSharp.Tests.Integrated/Server/Handlers/CookieHandlers.cs b/test/RestSharp.Tests.Integrated/Server/Handlers/CookieHandlers.cs
@@ -55,6 +55,16 @@ public static class CookieHandlers {
                 HttpOnly = true
             }
         );
+
+        ctx.Response.Cookies.Append(
+            "cookie_empty_domain",
+            "value_empty_domain",
+            new CookieOptions {
+                HttpOnly = true,
+                Domain = string.Empty
+            }
+        );
+
         return Results.Content("success");
     }
 }