Bug fix. Response cookie with empty domain fails #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fcastells
changed the title
alexeyzimarev
added a commit
that referenced
this pull request
Mar 12, 2023
* Added .NET Framework 471 as a target. .NET 5 is out * Fix the media type issue with .NET 7 #1969 * `IRestClient` Interface is back * String type for ContentType * Added Authenticator to RestRequest * Made Options immutable to make the client thread-safe * Ignore exceptions parsing response cookies (#2015) * V109 (#2010) * Added a simple factory with opt-in --------- Co-authored-by: Francesc Castells <fcastells76@gmail.com> Co-authored-by: Francesc Castells <francesc.castells@sermo.com> Co-authored-by: Edward Lichtman <E.Lichtman2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to issue 1792
When a response contains a Cookie header with an empty domain, the .NET library that parses the cookie throws an exception. This PR ignores cookie parsing exceptions so that the request does not fail due to malformed cookies. Instead, the cookie is ignored and the header is still accessible through the response headers.
Purpose
This pull request is a:
Checklist