Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a request body input handler for String bodies (text/plain). #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Infiniverse
Copy link

The code base has a String output mapper but doesn't have a String input mapper - which prevents String bodies from being submitted. This patch seeks to address that. Could you please consider merging? Thanks, Joe

@fcamblor
Copy link
Contributor

Could you please provide a test case (using a spec file for instance) to demonstrate the use case?

I think it should be something easy.

@Infiniverse
Copy link
Author

I looked for a test case, but couldn't find one. You're testing at the integration level though, with spec, right? So, I'll take a look at that later.

@Infiniverse
Copy link
Author

Ah, yes ok. My java 7 foo is weak, so I'll have to read up on streams.

@Infiniverse
Copy link
Author

Sorry to be dense, where are the integration spec tests?

@fcamblor
Copy link
Contributor

Sorry for the (very) late response, you can have a look at some spec in the samplest project, here for instance (and you can make a junit test testing this spec file following this example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants