Add full set of struct tests + changes to make them pass #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retep998
requested changes
Jun 3, 2018
src/um/commdlg.rs
Outdated
| nFromPage: DWORD, | ||
| nToPage: DWORD, | ||
| }} | ||
| pub type LPPRINTPAGERANGE = *mut PRINTPAGERANGE; | ||
| pub type PCPRINTPAGERANGE = *const PRINTPAGERANGE; | ||
| STRUCT!{struct PRINTDLGEXA { | ||
| STRUCT!{#[cfg_attr(target_arch = "x86", repr(packed))] struct PRINTDLGEXA { |
There was a problem hiding this comment.
Are these... double spaces I see? You monster!
src/um/setupapi.rs
Outdated
| @@ -32,25 +32,25 @@ pub const MAX_SERVICE_NAME_LEN: usize = 256; | |||
| pub const MAX_SUBTITLE_LEN: usize = 256; | |||
| pub const SP_MAX_MACHINENAME_LENGTH: usize = MAX_PATH + 3; | |||
| pub type HINF = PVOID; | |||
| STRUCT!{struct INFCONTEXT { | |||
| STRUCT!{#[cfg_attr(target_arch = "x86", repr(packed))] struct INFCONTEXT { | |||
There was a problem hiding this comment.
And even more of those double spaces!
retep998
approved these changes
Jun 3, 2018
ehuss
added a commit
to ehuss/atty
that referenced
this pull request
Jul 14, 2018
Ever since winapi version 0.3.5, tty detection for msys terminals has been broken. The definition for FILE_NAME_INFO struct changed in retep998/winapi-rs#607, causing the first character from the filename to be cut off.
ehuss
added a commit
to ehuss/atty
that referenced
this pull request
Jul 15, 2018
Ever since winapi version 0.3.5, tty detection for msys terminals has been broken. The definition for FILE_NAME_INFO struct changed in retep998/winapi-rs#607, causing the first character from the filename to be cut off.
mattlknight
pushed a commit
to mattlknight/winapi-rs
that referenced
this pull request
Aug 31, 2018
* Add full set of struct tests + changes to make them pass * Update tests + fixes * Update struct tests * Update tests + fixes * Update tests + changes * Fix double spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #442.
Fix summary:
One unresolved issue is SPPHRASE in sapi. The C and C++ definitions differ from each other and I'm unsure as to which is the correct definition. The C++ definition uses base classes which add padding the C definition does not.
Would you like the C code used to generate the tests added in as well?