Fix msys detection with new winapi. #28
Conversation
src/lib.rs
Outdated
| @@ -26,6 +26,7 @@ extern crate termion; | |||
|
|
|||
| #[cfg(windows)] | |||
| use winapi::shared::minwindef::DWORD; | |||
| use winapi::shared::ntdef::WCHAR; | |||
There was a problem hiding this comment.
Missing #[cfg(windows)] for winapi::shared::ntdef::WCHAR
Ever since winapi version 0.3.5, tty detection for msys terminals has been broken. The definition for FILE_NAME_INFO struct changed in retep998/winapi-rs#607, causing the first character from the filename to be cut off.
|
Nice fix! I think I buy it. @retep998 Was this sort of breakage intentional? Or was the way we were using |
|
Also, does this fix work with winapi |
|
That sort of breakage was not intentional, but it's also the sort of breakage that should not affect anyone because people should not be assuming that the offset of the unsized field is the same as the struct's size. The new code in this PR is definitely much better. Yes, it works with all winapi versions. |
I tested with winapi 0.3.0 on a variety of windows shells, and they all seem to behave correctly. |
winapi 0.3.5 changed how it represents some of its structs, which caused a bug to surface in atty that prevents tty detection on Windows. atty has an open PR to fix this: softprops/atty#28 Until a new release of atty, we pin winapi to a version that works.
|
Thank you folks! |
|
@retep998 @BurntSushi I tagged and published a new crate version 0.2.11 |
|
@softprops Awesome, thank you! |
Fix color detection for Windows msys terminals. Updates atty to pull in the fix softprops/atty#28. Closes rust-lang/cargo#5724.
Ever since winapi version 0.3.5, tty detection for msys terminals has been
broken. The definition for FILE_NAME_INFO struct changed in
retep998/winapi-rs#607, causing the first character from the filename to be cut
off.