Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement methods for iteration #317

Closed
wants to merge 4 commits into from
Closed

Implement methods for iteration #317

wants to merge 4 commits into from

Conversation

ivonx
Copy link
Contributor

@ivonx ivonx commented Jul 10, 2019

No description provided.

@ivonx ivonx requested a review from beatngu13 July 10, 2019 09:23
@rebazer rebazer force-pushed the feature/implement-getAllActionChangeSets-method branch 2 times, most recently from cf15229 to d18b0af Compare July 10, 2019 11:16
@ivonx ivonx force-pushed the feature/implement-getAllActionChangeSets-method branch from d18b0af to ff3c82a Compare July 10, 2019 12:29
@ivonx ivonx changed the title Implement getAllActionChangeSets method Implement methods for iteration Jul 10, 2019
@ivonx ivonx requested a review from beatngu13 July 10, 2019 12:30
@rebazer rebazer force-pushed the feature/implement-getAllActionChangeSets-method branch from ff3c82a to 37e34da Compare July 10, 2019 12:34
@rebazer rebazer force-pushed the feature/implement-getAllActionChangeSets-method branch from 37e34da to 7ab6664 Compare July 10, 2019 12:41
beatngu13
beatngu13 suggested changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@beatngu13 beatngu13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: Think about tests for those aggregation methods, which are a bit more critical. It's up to choose these methods.

src/main/java/de/retest/recheck/ui/review/ActionChangeSet.java Show resolved Hide resolved
src/main/java/de/retest/recheck/ui/review/ReviewResult.java Show resolved Hide resolved
src/main/java/de/retest/recheck/ui/review/ReviewResult.java Show resolved Hide resolved
@ivonx ivonx closed this Jul 11, 2019
@ivonx ivonx deleted the feature/implement-getAllActionChangeSets-method branch July 11, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatngu13 beatngu13 beatngu13 requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivonx @beatngu13