Refactor ActionReplayResult #514
Conversation
enesoezel
force-pushed
the
feature/refactor-action-replay-result
branch
from
dc230a5
to
7b4b8b1
Compare
There was a problem hiding this comment.
Please evaluate the usages of ActionReplayResult and guess the time, we would need for an update branch to adjust to these changes (with the deleted methods and such). Secondly, please guess the work in creating/updating tests for each of the specialized class.
Is the time we need to invest worth it for this change?
Also, please cleanup your commit history 😄
src/main/java/de/retest/recheck/review/AcceptableElementDifference.java
Outdated
Show resolved
Hide resolved
enesoezel
force-pushed
the
feature/refactor-action-replay-result
branch
4 times, most recently
from
d89015c
to
01b6907
Compare
rebazer
force-pushed
the
feature/refactor-action-replay-result
branch
2 times, most recently
from
c9e1eb5
to
82bf0d9
Compare
src/test/java/de/retest/recheck/report/ActionReplayResultTest.java
Outdated
Show resolved
Hide resolved
src/test/java/de/retest/recheck/report/ActionReplayResultTest.java
Outdated
Show resolved
Hide resolved
rebazer
force-pushed
the
feature/refactor-action-replay-result
branch
2 times, most recently
from
951c31d
to
6fc3a36
Compare
this is to simplify and gain access to the DifferenceRetriever, since this is needed for the metadata
this is to simplify and gain access to the DifferenceRetriever, since this is needed for the metadata
this is to simplify and gain access to the DifferenceRetriever, since this is needed for the metadata
rebazer
force-pushed
the
feature/refactor-action-replay-result
branch
from
6fc3a36
to
40b2403
Compare
rebazer
force-pushed
the
feature/refactor-action-replay-result
branch
3 times, most recently
from
92c42d3
to
f1003c9
Compare
enesoezel
force-pushed
the
feature/refactor-action-replay-result
branch
from
f1003c9
to
81c0999
Compare
rebazer
force-pushed
the
feature/refactor-action-replay-result
branch
from
81c0999
to
5eb9656
Compare
|
Rebase failed, this pull request needs some manual love ... |
25 similar comments
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Rebase failed, this pull request needs some manual love ... |
|
Close until conflicts have been resolved. |
|
Rebase failed, this pull request needs some manual love ... |
Draft pull request for feedback from @diba1013