Feature/switch to rhino #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enesoezel
force-pushed
the
feature/switch-to-rhino
branch
from
fdb47e1
to
6b4a7cb
Compare
|
Since you needed to adapt a test, is there any other compatibility problems with rhino?
|
rebazer
force-pushed
the
feature/switch-to-rhino
branch
from
6b4a7cb
to
a12ff93
Compare
|
As I mentioned in the description it seems like recheck-web is working proper. The ignore file works also. Regarding this stackoverflow post, a simple cast does also work like: |
rebazer
force-pushed
the
feature/switch-to-rhino
branch
2 times, most recently
from
b100ef7
to
934e703
Compare
|
So, too me it looks like this variant is superior to #527. Any objections against merging and testing it during dev and especially when releasing 1.8.0? |
|
I am also in favor of merging now and testing throughout the sprint. |
rebazer
force-pushed
the
feature/switch-to-rhino
branch
from
934e703
to
b418962
Compare
rebazer
force-pushed
the
feature/switch-to-rhino
branch
3 times, most recently
from
7c3c566
to
b6ff4e9
Compare
roesslerj
approved these changes
Nov 29, 2019
rebazer
force-pushed
the
feature/switch-to-rhino
branch
2 times, most recently
from
124d80b
to
47fadc9
Compare
beatngu13
approved these changes
Dec 2, 2019
rebazer
force-pushed
the
feature/switch-to-rhino
branch
4 times, most recently
from
b1596cf
to
524285e
Compare
enesoezel
force-pushed
the
feature/switch-to-rhino
branch
from
524285e
to
02a879e
Compare
beatngu13
added a commit
that referenced
this pull request
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's almost no difference in size regarding the recheck-web jars.
All IT-Test in recheck-web seem to work as before.
resolves #331