Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.tableCreate() not defined in JS #46

Closed
neumino opened this issue Nov 13, 2012 · 12 comments
Closed

r.tableCreate() not defined in JS #46

neumino opened this issue Nov 13, 2012 · 12 comments
Assignees
Milestone

Comments

@neumino
Copy link
Member

neumino commented Nov 13, 2012

So r.table('table_name') is a shortcut for r.db('test').table('table_name')
However, r.tableCreate('new_table') doesn't work in javascript (at least).

Can we have all methods after db() to work after r. by using the default database 'test'?
In that case, in the data explorer, I can suggest users r.table(), r.tableCreate(), r.tableDrop(), r.tableList() etc...

@coffeemug
Copy link
Contributor

It makes sense to me to be able to support tableCreate and friends on the default db on the connection. BTW, eventually we'll add a dropdown to the data explorer that will denote the default database to run ops on. Moving to backlog though, because there are more important things to work out for now.

@mlucy
Copy link
Member

mlucy commented May 1, 2013

This is in code-review 476 by @Tryneus .

The code-review includes the server changes and updates to the ruby tests. @wmrowan -- when you have some time, could you update the python/js drivers/tests in the branch 46_bare_tablecreate?

@coffeemug
Copy link
Contributor

@mlucy, @wmrowan -- what's the state of this change? I know it isn't slated, but man would it make my life easier! (also, it would need YAML docs)

@mlucy
Copy link
Member

mlucy commented May 2, 2013

The server change and ruby driver implementation are done. If Bill has time this could make 1.5 pretty easily.

@danielmewes
Copy link
Member

Is the short version for table_list included? I don't see such a change in 46_bare_tablecreate . Am I just looking at the wrong place?
(it also doesn't seem to update the descriptions in the ql2.proto file)

@mlucy
Copy link
Member

mlucy commented May 2, 2013

Whoops, yeah, missed that entirely. I'll add that tomorrow.

@mlucy
Copy link
Member

mlucy commented May 2, 2013

(I'll update the ql2.proto file too.)

@danielmewes
Copy link
Member

Cool, thanks.

-----Original Message-----
From: Michael Lucy notifications@github.com
Date: Thu, 02 May 2013 04:32:19
To: rethinkdb/rethinkdbrethinkdb@noreply.github.com
Reply-To: rethinkdb/rethinkdb reply@reply.github.com
Cc: Daniel Mewesdanielmewes@onlinehome.de
Subject: Re: [rethinkdb] r.tableCreate() not defined in JS (#46)

Whoops, yeah, missed that entirely. I'll add that tomorrow.


Reply to this email directly or view it on GitHub:
#46 (comment)

@mlucy
Copy link
Member

mlucy commented May 3, 2013

table_list and updates to the .proto file are in the code-review

@wmrowan
Copy link
Contributor

wmrowan commented May 3, 2013

@mlucy The JS and PY implementations have been pushed to branch 46_bare_tablecreate.

@mlucy
Copy link
Member

mlucy commented May 4, 2013

@wmrowan: Awesome. I updated the code-review; this should be in next soon.

@mlucy
Copy link
Member

mlucy commented May 7, 2013

This is now in next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants