Turn on warnings for stress client compilation.

[srh]

While compiling the stress client on OS X, I got some warnings and realized that I'd be much more comfortable if -Werror was turned on, not to mention -Wall and -Wextra. This has a good chance of preventing wild goose chases when exhibiting bugs on platforms other than the commonly used ones.

[srh]

Good news everybody. Lots of code in the stress client was just flat-out broken and has been caught thanks to turning on warnings.

[coffeemug]

The stress client only works if you're very, very flexible about your
definition of the word "works". I wouldn't spend any time fixing it, it
basically needs to be rewritten in its entirety (or at the very least,
extremely heavily refactored).

On Tue, Nov 20, 2012 at 9:51 PM, srh notifications@github.com wrote:

Good news everybody. Lots of code in the stress client was just flat-out
broken and has been caught thanks to turning on warnings.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/96#issuecomment-10586400.

[srh]

Too late. The changes in branch sam_96 are in review. It was not particularly difficult or time-consuming, and the benefit is that if we keep hacking at the existing stress client, we'll have warnings.

[coffeemug]

@srh -- should this be closed?

[srh]

Yes. Fixed as of 4081af8. Review 88.