Option to return partial models #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be taken care of after #8. |
|
PS: The impact of this feature is at the moment impaired, because we cannot correctly partially validate partial models with nested ModelTypes in schematics<2.0.1. See schematics/schematics#544 |
* Supercell always validates the output model in the provider before its serialization is returned by the handler. If you want to return a partial model, this will result in an internal error (500) due to potentially missing required fields. * A keyword parameter is added to the provide decorator, signalling that the return model validation should not raise validation errors for partial models, if set to true. The default value is False.
* It turns out, the partial validation is not correctly working in version of schematics<2.0.1. A test for this was added, which is skipped if the currently used schematics version is older. This is the case as long as supercell is still using the old 1.1.1 version of schematics.
peldszus
force-pushed
the
option-to-return-partial-models
branch
from
9e62ef2
to
9d81490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.