Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::enable_if as pfi::lang::enable_if #220

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Conversation

ysk24ok
Copy link
Contributor

@ysk24ok ysk24ok commented Nov 10, 2020

This change contains backward incompatibility, so I've opened this as draft pullreq to get feedback.

Changes

This pullreq uses std::enable_if as pfi::lang_enable_if
because C++11 has std::enable_if and pficommon does not need to maintain its own implementation.

Backward Incompatibility

The template parameter of pfi::lang::enable_if and pfi::lang::disable_if has changed.

@ysk24ok ysk24ok marked this pull request as ready for review November 16, 2020 07:27
@ysk24ok
Copy link
Contributor Author

ysk24ok commented Nov 17, 2020

In 924b5d4 , I added a document for pfi::lang::enable_if .
It's not deprecated so the usage and an example code are included in the document.

@takei-yuya
Copy link
Member

LGTM!!

@takei-yuya takei-yuya merged commit a981963 into v4.0 Nov 26, 2020
@ysk24ok ysk24ok deleted the using_std_enable_if branch November 26, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants