Fix broken confy::load call #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #74
silvercurrently uses themasterbranch ofconfy, which lead to the breaking change mentioned above.This PR works around this by pinning the latest released version, which is compatible with this code base. When the next version of confy is released, the call to
confy::load("silver")inmain.rstwill need to be replaced withconfy::load("silver", None)The deeper issue still needs to be fixed: the dependency should have a pinned version. Building off master is begging for incompatibilities like this in the future.
CC @j0hnmeow