Fix crash in Item details panel with certain emoji characters #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reupen
force-pushed
the
fix-item-details-emoji-crash
branch
2 times, most recently
from
0086e76
to
787801b
Compare
#321 This rewrites the sizing and word wrapping logic in the Items detail panel to fix a crash or possible heap corruption when Unicode code points above U+FFFF were encountered. These changes include making Item details work in only UTF-16 internally; previously there was a mix of UTF-8 and UTF-16 which lead to complexity in counting code units. Word wrapping behaviour will be slightly different to previous versions as a result of these changes.
reupen
force-pushed
the
fix-item-details-emoji-crash
branch
from
787801b
to
2db7d22
Compare
reupen
added a commit
that referenced
this pull request
May 18, 2021
This fixes a regression caused by #323 where, when scrolling down in the Item details panel, colour codes would misbehave or more rarely a crash could occur.
reupen
added a commit
that referenced
this pull request
May 18, 2021
This fixes a regression caused by #323 where, when scrolling down in the Item details panel, colour codes would misbehave or, more rarely, a crash could occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#321
This rewrites the sizing and word wrapping logic in the Items detail panel to fix a crash or possible heap corruption when Unicode code points above U+FFFF were encountered.
These changes include making Item details work in only UTF-16 internally; previously there was a mix of UTF-8 and UTF-16 which lead to complexity in counting code units.
Word wrapping behaviour will be slightly different to previous versions as a result of these changes.