Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Universal patch): Shared patch to trust user certificates #1216

Closed
3 tasks done
bennett-sh opened this issue Mar 28, 2023 · 4 comments
Closed
3 tasks done

feat(Universal patch): Shared patch to trust user certificates #1216

bennett-sh opened this issue Mar 28, 2023 · 4 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@bennett-sh
Copy link
Contributor

Application

All apps

Issue

It's interesting to inspect HTTPS traffic but most apps only trust system and not user certificates making it much harder.

Patch

  1. Does the manifest's application tag have android:networkSecurityConfig="@xml/SOMETHING"?
    |> If not, create xml/network_security_config.xml and add it to the manifest.
<?xml version="1.0" encoding="utf-8"?>
<network-security-config>
  <base-config>
      <trust-anchors>
          <certificates src="system" />
          <certificates src="user" overridePins="true" />
      </trust-anchors>
  </base-config>
</network-security-config>

|> If yes, add the <certificates src="user" overridePins="true" />-element

Motivation

My motivation is that it improves the work of many people by speeding up app patching and making HTTPS interception without root easier.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@bennett-sh bennett-sh added the Feature request Requesting a new feature that's not implemented yet label Mar 28, 2023
@proxykingdev
Copy link

simply adding this XML will not solve your problem.

@Axelen123
Copy link
Member

apk-mitm already exists

@bennett-sh
Copy link
Contributor Author

yes but it makes everything more complicated since I'll have to go through a secondary step on my pc (or termux; unsure if it works) everytime I want to update an app

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.141.0](ReVanced/revanced-patches@v2.140.0...v2.141.0) (2022-12-09)

### Bug Fixes

* inconsistencies in preference switches ([ReVanced#1207](ReVanced/revanced-patches#1207)) ([b6ea5a4](ReVanced/revanced-patches@392dc72))

### Features

* **youtube/return-youtube-dislike:** simplify preference descriptions ([ReVanced#1216](ReVanced/revanced-patches#1216)) ([514b5da](ReVanced/revanced-patches@2f9241f))
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat(patch): Shared patch to trust user certificates feat(Universal patch): Shared patch to trust user certificates Apr 2, 2024
@oSumAtrIX
Copy link
Member

Should be possible now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

4 participants