Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: YT - Full screen layout misaligned #1339

Closed
3 tasks done
kyoforkshomebrews opened this issue Feb 16, 2023 · 4 comments
Closed
3 tasks done

bug: YT - Full screen layout misaligned #1339

kyoforkshomebrews opened this issue Feb 16, 2023 · 4 comments
Labels
Bug report Something isn't working

Comments

@kyoforkshomebrews
Copy link

kyoforkshomebrews commented Feb 16, 2023

Type

Error at runtime

Bug description

On every video in fullscreen the title bar is a little too far down.

Steps to reproduce

Step 1: Open any video
Step 2: Pause it
Step 3: Fullscreen it
Step 4: See that parts of the UI are misaligned

Relevant log output

02-17 00:07:42.674 11688 11688 I DecorView[]: pkgName:app.revanced.android.youtube old windowMode:1 new windoMode:1, isFixedSize:false
02-17 00:07:43.755  1631  1740 D StatusBarManagerService: win:Window{5a89731 u0 app.revanced.android.youtube/com.google.android.apps.youtube.app.watchwhile.WatchWhileActivity}mIsColorEnable:truelight:false
02-17 00:07:43.756  1631  1740 I StatusBarDisable: setFlags what=0 which=1 pkg=Window{5a89731 u0 app.revanced.android.youtube/com.google.android.apps.youtube.app.watchwhile.WatchWhileActivity}
02-17 00:07:43.761  1631  4124 I WindowManager: dispatchResized : win = Window{5a89731 u0 app.revanced.android.youtube/com.google.android.apps.youtube.app.watchwhile.WatchWhileActivity} drawState = DRAW_PENDING
02-17 00:07:43.817 11688 11688 I DecorView[]: pkgName:app.revanced.android.youtube old windowMode:1 new windoMode:1, isFixedSize:false
02-17 00:07:43.824  1631  1740 D StatusBarManagerService: win:Window{5a89731 u0 app.revanced.android.youtube/com.google.android.apps.youtube.app.watchwhile.WatchWhileActivity}mIsColorEnable:truelight:false
02-17 00:07:43.824  1631  1740 I StatusBarDisable: setFlags what=0 which=1 pkg=Window{5a89731 u0 app.revanced.android.youtube/com.google.android.apps.youtube.app.watchwhile.WatchWhileActivity}
02-17 00:07:43.828  1631  4135 I WindowManager:   SURFACE SIZE 2340x1080: app.revanced.android.youtube/com.google.android.apps.youtube.app.watchwhile.WatchWhileActivity
02-17 00:07:43.838  1631  4135 I WindowManager: dispatchResized : win = Window{5a89731 u0 app.revanced.android.youtube/com.google.android.apps.youtube.app.watchwhile.WatchWhileActivity} drawState = DRAW_PENDING
02-17 00:07:43.937  4005  4005 I GoogleInputMethodService: GoogleInputMethodService.onStartInput():1877 onStartInput(EditorInfo{inputType=0x0(NULL) imeOptions=0x0 privateImeOptions=null actionName=UNSPECIFIED actionLabel=null actionId=0 initialSelStart=-1 initialSelEnd=-1 initialCapsMode=0x0 hintText=null label=null packageName=app.revanced.android.youtube fieldId=-1 fieldName=null extras=null}, true)
02-17 00:07:44.042 11688 11688 I DecorView[]: pkgName:app.revanced.android.youtube old windowMode:1 new windoMode:1, isFixedSize:false
02-17 00:07:44.084   674   753 W BufferQueueProducer: [app.revanced.android.youtube/com.google.android.apps.youtube.app.watchwhile.WatchWhileActivity#0]:1390: disconnect: not connected (req=1)
02-17 00:07:44.172 11688 11688 W View    : requestLayout() improperly called by com.google.android.apps.youtube.app.player.overlay.SizeAdjustableOverlayWrapperLayout{3a88bd8 V.E...... ......ID 0,0-2340,1080} during layout: running second layout pass
02-17 00:07:44.172 11688 11688 W View    : requestLayout() improperly called by com.google.android.apps.youtube.app.player.overlay.SizeAdjustableOverlayWrapperLayout{6cd6216 V.E...... ......ID 0,0-2340,1080} during layout: running second layout pass
02-17 00:07:44.172 11688 11688 W View    : requestLayout() improperly called by com.google.android.apps.youtube.app.player.overlay.SizeAdjustableOverlayWrapperLayout{b0a7f94 V.E...... ......ID 0,0-2340,1080} during layout: running second layout pass
02-17 00:07:44.314   674   754 W BufferQueueProducer: [app.revanced.android.youtube/com.google.android.apps.youtube.app.watchwhile.WatchWhileActivity#0]:1390: disconnect: not connected (req=1)

Screenshots or videos

Screenshot_20230216_143151_app revanced android youtube

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@kyoforkshomebrews kyoforkshomebrews added the Bug report Something isn't working label Feb 16, 2023
@oSumAtrIX
Copy link
Member

oSumAtrIX commented Feb 16, 2023

Dupe of another issue, cant find it now though sry. Btw, caused by the option to restore the tablet layout for the minimized player.

@kyoforkshomebrews
Copy link
Author

Are you sure..? I just searched every possible term with no matching results.

@oSumAtrIX
Copy link
Member

Yeah I am sure, I wouldn't know the "cause" otherwise (OP told me).

@kyoforkshomebrews
Copy link
Author

k. thanks for the info.

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.148.0](ReVanced/revanced-patches@v2.147.0...v2.148.0) (2022-12-29)

### Bug Fixes

* **youtube/general-ads:** don't early return when not necessary ([ReVanced#1353](ReVanced/revanced-patches#1353)) ([003a400](ReVanced/revanced-patches@bbda14f))

### Features

* **tasker:** `unlock-license` patch ([ReVanced#1339](ReVanced/revanced-patches#1339)) ([78a43b8](ReVanced/revanced-patches@c2fdd69))
* **twitter:** `hide-views-stats` patch ([ReVanced#1371](ReVanced/revanced-patches#1371)) ([2f04a06](ReVanced/revanced-patches@8c479e2))
* **youtube/general-ads-patch:** hide guidelines for subscriber ([ReVanced#1352](ReVanced/revanced-patches#1352)) ([2d10932](ReVanced/revanced-patches@fb8de2e))
* **youtube/theme:** add option to color the seekbar ([53b91fe](ReVanced/revanced-patches@166c8f0))
* **youtube/theme:** include the patch by default ([c363997](ReVanced/revanced-patches@0297e18))
* **youtube:** `hide-breaking-news-shelf` patch ([ReVanced#1381](ReVanced/revanced-patches#1381)) ([38a9877](ReVanced/revanced-patches@5007d78))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants