Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube Music): "Don't Play Music Videos" option #1353

Closed
3 tasks done
NarrikSynthfox opened this issue Feb 12, 2023 · 15 comments
Closed
3 tasks done

feat(YouTube Music): "Don't Play Music Videos" option #1353

NarrikSynthfox opened this issue Feb 12, 2023 · 15 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@NarrikSynthfox
Copy link

NarrikSynthfox commented Feb 12, 2023

Application

Youtube Music

Issue

For premium users, theres an option that makes it so that it doesn't play the music video version of songs when only playing audio. If it's possible to allow that to be used tor non-premium users, that would be great. Some songs, the music videos have long intros or sfx over the music that isn't in the streaming upload of the song.

Patch

Show the option for "Don't play music videos" (I think thats what it's labeled as) for all users.

Motivation

I have seen a lot of people requesting SponsorBlock for Youtube Music, and most of the reasons why would be solved with this patch. Hopefully its possible to accomplish.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@NarrikSynthfox NarrikSynthfox added the Feature request Requesting a new feature that's not implemented yet label Feb 12, 2023
@oSumAtrIX
Copy link
Member

The stream the API sends you can not be changed.

@NarrikSynthfox
Copy link
Author

Yeah, but there is an option that is built in natively to YouTube Music, that only shows up for premium users, and I was wondering if it were possible to make it show up for non-premium as well somehow.

@oSumAtrIX
Copy link
Member

I don't think so. The API will only work if the user is known to have premium.

@ILoveOpenSourceApplications
Copy link
Contributor

Well I don't know about the premium part, but I'm pretty sure that RVX has a patch which does this.

@oSumAtrIX
Copy link
Member

Please link the relevant commits.

@ILoveOpenSourceApplications
Copy link
Contributor

Screenshot_20230212-183723~2
This is the result of the patch. I can't seem to find the commit though.

@oSumAtrIX
Copy link
Member

You can use "git blame" to find the commit to the code which enables it, please then send a commit link.

@ILoveOpenSourceApplications
Copy link
Contributor

How do I do this exactly? Not very used to GitHub actually.

@oSumAtrIX
Copy link
Member

This and this might be helpful for you.

@ILoveOpenSourceApplications
Copy link
Contributor

I have a doubt. Don't we have exclusive audio playback option? Doesn't it play just the audio only? I think the one I mentioned above does the same only.

@oSumAtrIX
Copy link
Member

I believe so too

@NarrikSynthfox
Copy link
Author

It does play audio only, but it's the audio for the music video.

@ILoveOpenSourceApplications
Copy link
Contributor

Sorry for the high hopes if I gave you any @NarrikSynthfox, but I don't think there's any patch atm which purely shifts from video mode to audio mode of the same song.

@HMartusewiczVox
Copy link

HMartusewiczVox commented Aug 29, 2023

I recently discovered this projects and they've done it:
vfsfitvnm/ViMusic#88
@oSumAtrIX can you reopen the issue?

@oSumAtrIX oSumAtrIX reopened this Aug 30, 2023
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.148.0-dev.3](ReVanced/revanced-patches@v2.148.0-dev.2...v2.148.0-dev.3) (2022-12-26)

### Bug Fixes

* **youtube/general-ads:** don't early return when not necessary ([ReVanced#1353](ReVanced/revanced-patches#1353)) ([003a400](ReVanced/revanced-patches@bbda14f))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.148.0](ReVanced/revanced-patches@v2.147.0...v2.148.0) (2022-12-29)

### Bug Fixes

* **youtube/general-ads:** don't early return when not necessary ([ReVanced#1353](ReVanced/revanced-patches#1353)) ([003a400](ReVanced/revanced-patches@bbda14f))

### Features

* **tasker:** `unlock-license` patch ([ReVanced#1339](ReVanced/revanced-patches#1339)) ([78a43b8](ReVanced/revanced-patches@c2fdd69))
* **twitter:** `hide-views-stats` patch ([ReVanced#1371](ReVanced/revanced-patches#1371)) ([2f04a06](ReVanced/revanced-patches@8c479e2))
* **youtube/general-ads-patch:** hide guidelines for subscriber ([ReVanced#1352](ReVanced/revanced-patches#1352)) ([2d10932](ReVanced/revanced-patches@fb8de2e))
* **youtube/theme:** add option to color the seekbar ([53b91fe](ReVanced/revanced-patches@166c8f0))
* **youtube/theme:** include the patch by default ([c363997](ReVanced/revanced-patches@0297e18))
* **youtube:** `hide-breaking-news-shelf` patch ([ReVanced#1381](ReVanced/revanced-patches#1381)) ([38a9877](ReVanced/revanced-patches@5007d78))
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title Patch Request: "Don't Play Music Videos" option. feat(YouTube Music): "Don't Play Music Videos" option Apr 2, 2024
@oSumAtrIX
Copy link
Member

Over time, a lot of feature requests have been made, which is why I am closing some according to the contribution guidelines:

Requests can be accepted or rejected at the discretion of maintainers of ReVanced Patches

This feature request has been closed for one or more of the following reasons:

  • Stale for too long
  • Low priority
  • Maintainers un-interested
  • Too complex to realize

Regardless, anyone who comes across this feature request can PR it. Thanks for the feature request!

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

4 participants