Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(patch): #1868

Closed
3 tasks done
Ryujin9610 opened this issue Oct 28, 2022 · 4 comments
Closed
3 tasks done

feat(patch): #1868

Ryujin9610 opened this issue Oct 28, 2022 · 4 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@Ryujin9610
Copy link

Ryujin9610 commented Oct 28, 2022

Application

Revanced youtube

Issue

When i have 1 of my fingers in the player window it activates the "hold & swipe time seek" function. Super annoying when watching something and it activates and pops up and or swipe accidentally.

Patch

Idk if it was intergrated in the "press to swipe gestrure" patch in the swipe controls section, but anyways disabling or activiting it doesnt change it. Would be nice if the patch gets added or fixed if its that one in the section i mentioned. Atleast a toggleable option for it.

Motivation

Its rlly a annoying thing while watching, so making a toggleable option for it so it can be disabled is a huge annoyance removal for mobile users.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@Ryujin9610 Ryujin9610 added the Feature request Requesting a new feature that's not implemented yet label Oct 28, 2022
@oSumAtrIX
Copy link
Member

How is it a "huge annoyance", simply don't hold 1 of your finger on the screen.

@Ryujin9610
Copy link
Author

How is it a "huge annoyance", simply don't hold 1 of your finger on the screen.

Yea sure dude, try to hold the phone with 1 hand comfy while watching in bed without touching the screen🤷‍♂️ "simply dont hold youre screen with one finger" is an equivalent in this case as "then dont watch to ads when they come up" or something else. But whatever lol

@oSumAtrIX
Copy link
Member

If I watch a video, I generally do not want a finger in front of the video, which is why I hold the phone on the side. Problem solved.

@Ryujin9610
Copy link
Author

Who says i dont have my phone in full screen in landscape mode and holding on the side? Second when you have it in fullscreen it has black bars on the side not enough for putting fingers infront of the video. Third thing, why having that "feature" if you could tap on the left or right and scroll on the seekbar? Kinda useless, especially if you dont need/want it and cant turn it off nowhere.

@revanced-bot revanced-bot transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.169.0-dev.1](ReVanced/revanced-patches@v2.168.0...v2.169.0-dev.1) (2023-04-21)

### Bug Fixes

* add missing annotation to patches ([ReVanced#1882](ReVanced/revanced-patches#1882)) ([d86b6a4](ReVanced/revanced-patches@b6a7640))
* **youtube/hide-video-action-buttons:** change 'Hide create, clip and thanks buttons' to default off ([ReVanced#1923](ReVanced/revanced-patches#1923)) ([fc89c86](ReVanced/revanced-patches@f007c5e))
* **youtube/hide-video-action-buttons:** fix 'hide share button' ([ReVanced#1924](ReVanced/revanced-patches#1924)) ([bc05e44](ReVanced/revanced-patches@7f518de))
* **youtube/microg-support:** remove incorrect patch dependency ([3e0c45c](ReVanced/revanced-patches@2ec08b3))
* **youtube/microg-support:** rename patch correctly ([091a25d](ReVanced/revanced-patches@3b726f3))
* **youtube/return-youtube-dislike:** render dislikes when scrolling into the screen ([ReVanced#1873](ReVanced/revanced-patches#1873)) ([85675b8](ReVanced/revanced-patches@d9dc58d))
* **youtube/sponsorblock:** do not depend on `remember-playback-speed` patch ([b0834fa](ReVanced/revanced-patches@cbbd6bb))
* **youtube/sponsorblock:** fix autorepeat button layout ([ReVanced#1868](ReVanced/revanced-patches#1868)) ([5e148d9](ReVanced/revanced-patches@ddee5f0))
* **youtube/spoof-signature-verification:** depend on `client-spoof` patch ([0d47375](ReVanced/revanced-patches@e826053))
* **youtubevanced/hide-ads:** hide more types of ads ([ReVanced#1781](ReVanced/revanced-patches#1781)) ([47ff447](ReVanced/revanced-patches@9a2430e))
* **youtubevanced/hide-ads:** remove broken ad filter ([ReVanced#1881](ReVanced/revanced-patches#1881)) ([5b987e1](ReVanced/revanced-patches@2835d1a))

### Features

* `change-package-name` patch ([ReVanced#1864](ReVanced/revanced-patches#1864)) ([f9a6672](ReVanced/revanced-patches@4bf3e77))
* `enable-android-debugging` patch ([ReVanced#1876](ReVanced/revanced-patches#1876)) ([bd224d9](ReVanced/revanced-patches@3dde507))
* **facebook:** `hide-inbox-ads` patch ([ReVanced#1893](ReVanced/revanced-patches#1893)) ([2cfc982](ReVanced/revanced-patches@a748510))
* **id-austria:** bump compatibility to `2.6.0` ([ReVanced#1827](ReVanced/revanced-patches#1827)) ([f48e794](ReVanced/revanced-patches@0dfd736))
* **inshorts:** `hide-ads` patch ([ReVanced#1828](ReVanced/revanced-patches#1828)) ([04a2acc](ReVanced/revanced-patches@a8c6031))
* **memegenerator:** `unlock-pro` patch ([ReVanced#1902](ReVanced/revanced-patches#1902)) ([7d30541](ReVanced/revanced-patches@003d0a1))
* **photomath/unlock-plus:** bump compatibility to `8.21.1` ([ReVanced#1926](ReVanced/revanced-patches#1926)) ([beb8d9c](ReVanced/revanced-patches@2b60efa))
* **photomath:** bump compatibility up to `8.21.0` ([ReVanced#1886](ReVanced/revanced-patches#1886)) ([43464fd](ReVanced/revanced-patches@fe58100))
* **reddit:** bump compatibility to `2023.12.0` ([ReVanced#1825](ReVanced/revanced-patches#1825)) ([e3666e6](ReVanced/revanced-patches@a003ec1))
* use better patch description ([32fcd25](ReVanced/revanced-patches@3de9938))
* **youtube-music:** `bypass-certificate-checks` patch ([ReVanced#1810](ReVanced/revanced-patches#1810)) ([ef8f26f](ReVanced/revanced-patches@7d7336d))
* **youtube/settings:** disable preferences and add dialog messages to preferences ([ReVanced#1801](ReVanced/revanced-patches#1801)) ([05023ba](ReVanced/revanced-patches@94261ce))
* **youtube/sponsorblock:** skip to video highlight ([ReVanced#1874](ReVanced/revanced-patches#1874)) ([83747b7](ReVanced/revanced-patches@96bdc2e))
* **youtube:** bump compatibility to `18.08.37` ([29561ec](ReVanced/revanced-patches@45f96a6))
* **youtube:** change default video speed and quality inside the settings menu ([ReVanced#1880](ReVanced/revanced-patches#1880)) ([fbb1763](ReVanced/revanced-patches@12c2fd5))
* **youtube:** constrain compatibility to `18.08.37` ([7403fc8](ReVanced/revanced-patches@cdee745))
* **youtube:** sponsorblock improvements ([ReVanced#1557](ReVanced/revanced-patches#1557)) ([b5d712a](ReVanced/revanced-patches@5e0ffbd))
* **youtube:** support version `18.08.37` ([4f4ceab](ReVanced/revanced-patches@fed3fe1))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
# [2.169.0](ReVanced/revanced-patches@v2.168.0...v2.169.0) (2023-04-21)

### Bug Fixes

* add missing annotation to patches ([ReVanced#1882](ReVanced/revanced-patches#1882)) ([d86b6a4](ReVanced/revanced-patches@b6a7640))
* **youtube/hide-video-action-buttons:** change 'Hide create, clip and thanks buttons' to default off ([ReVanced#1923](ReVanced/revanced-patches#1923)) ([fc89c86](ReVanced/revanced-patches@f007c5e))
* **youtube/hide-video-action-buttons:** fix 'hide share button' ([ReVanced#1924](ReVanced/revanced-patches#1924)) ([bc05e44](ReVanced/revanced-patches@7f518de))
* **youtube/microg-support:** remove incorrect patch dependency ([3e0c45c](ReVanced/revanced-patches@2ec08b3))
* **youtube/microg-support:** rename patch correctly ([091a25d](ReVanced/revanced-patches@3b726f3))
* **youtube/return-youtube-dislike:** render dislikes when scrolling into the screen ([ReVanced#1873](ReVanced/revanced-patches#1873)) ([85675b8](ReVanced/revanced-patches@d9dc58d))
* **youtube/sponsorblock:** do not depend on `remember-playback-speed` patch ([b0834fa](ReVanced/revanced-patches@cbbd6bb))
* **youtube/sponsorblock:** fix autorepeat button layout ([ReVanced#1868](ReVanced/revanced-patches#1868)) ([5e148d9](ReVanced/revanced-patches@ddee5f0))
* **youtube/spoof-signature-verification:** depend on `client-spoof` patch ([0d47375](ReVanced/revanced-patches@e826053))
* **youtubevanced/hide-ads:** hide more types of ads ([ReVanced#1781](ReVanced/revanced-patches#1781)) ([47ff447](ReVanced/revanced-patches@9a2430e))
* **youtubevanced/hide-ads:** remove broken ad filter ([ReVanced#1881](ReVanced/revanced-patches#1881)) ([5b987e1](ReVanced/revanced-patches@2835d1a))

### Features

* `change-package-name` patch ([ReVanced#1864](ReVanced/revanced-patches#1864)) ([f9a6672](ReVanced/revanced-patches@4bf3e77))
* `enable-android-debugging` patch ([ReVanced#1876](ReVanced/revanced-patches#1876)) ([bd224d9](ReVanced/revanced-patches@3dde507))
* **facebook:** `hide-inbox-ads` patch ([ReVanced#1893](ReVanced/revanced-patches#1893)) ([2cfc982](ReVanced/revanced-patches@a748510))
* **id-austria:** bump compatibility to `2.6.0` ([ReVanced#1827](ReVanced/revanced-patches#1827)) ([f48e794](ReVanced/revanced-patches@0dfd736))
* **inshorts:** `hide-ads` patch ([ReVanced#1828](ReVanced/revanced-patches#1828)) ([04a2acc](ReVanced/revanced-patches@a8c6031))
* **memegenerator:** `unlock-pro` patch ([ReVanced#1902](ReVanced/revanced-patches#1902)) ([7d30541](ReVanced/revanced-patches@003d0a1))
* **photomath/unlock-plus:** bump compatibility to `8.21.1` ([ReVanced#1926](ReVanced/revanced-patches#1926)) ([beb8d9c](ReVanced/revanced-patches@2b60efa))
* **photomath:** bump compatibility up to `8.21.0` ([ReVanced#1886](ReVanced/revanced-patches#1886)) ([43464fd](ReVanced/revanced-patches@fe58100))
* **reddit:** bump compatibility to `2023.12.0` ([ReVanced#1825](ReVanced/revanced-patches#1825)) ([e3666e6](ReVanced/revanced-patches@a003ec1))
* use better patch description ([32fcd25](ReVanced/revanced-patches@3de9938))
* **youtube-music:** `bypass-certificate-checks` patch ([ReVanced#1810](ReVanced/revanced-patches#1810)) ([ef8f26f](ReVanced/revanced-patches@7d7336d))
* **youtube/settings:** disable preferences and add dialog messages to preferences ([ReVanced#1801](ReVanced/revanced-patches#1801)) ([05023ba](ReVanced/revanced-patches@94261ce))
* **youtube/sponsorblock:** skip to video highlight ([ReVanced#1874](ReVanced/revanced-patches#1874)) ([83747b7](ReVanced/revanced-patches@96bdc2e))
* **youtube:** bump compatibility to `18.08.37` ([29561ec](ReVanced/revanced-patches@45f96a6))
* **youtube:** change default video speed and quality inside the settings menu ([ReVanced#1880](ReVanced/revanced-patches#1880)) ([fbb1763](ReVanced/revanced-patches@12c2fd5))
* **youtube:** constrain compatibility to `18.08.37` ([7403fc8](ReVanced/revanced-patches@cdee745))
* **youtube:** sponsorblock improvements ([ReVanced#1557](ReVanced/revanced-patches#1557)) ([b5d712a](ReVanced/revanced-patches@5e0ffbd))
* **youtube:** support version `18.08.37` ([4f4ceab](ReVanced/revanced-patches@fed3fe1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

2 participants