Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (YT) : Premium Header + Wide Search Bar appearing simultaneously. #2438

Closed
3 tasks done
Aryan-Chauhan opened this issue Dec 15, 2023 · 3 comments
Closed
3 tasks done

feat (YT) : Premium Header + Wide Search Bar appearing simultaneously. #2438

Aryan-Chauhan opened this issue Dec 15, 2023 · 3 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@Aryan-Chauhan
Copy link

Feature description

It is requested please add a feature where "Premium Header" and "Wide Search Bar" appear simultaneously side-by-side.
Screenshot_2023-12-15-09-13-11-09_f22faf49515899f9781ec174a4d85388
Screenshot_2023-12-15-09-14-57-69_f22faf49515899f9781ec174a4d85388

Motivation

1.) After the introduction of You tab, space has increased on the top header. So, both Premium Header & Wide Search bar can be occupied.

2.) Search button is a basic feature, so it should have a bigger bar without compromising on the Premium Header.

Thank you.

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@Aryan-Chauhan Aryan-Chauhan added the Feature request Requesting a new feature that's not implemented yet label Dec 15, 2023
@oSumAtrIX
Copy link
Member

The wide search bar has a functional purpose unlike the header. Chose either

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@semantic-release-bot
chore(release): 2.178.0-dev.2 [skip ci]
3400e2a 
# [2.178.0-dev.2](ReVanced/revanced-patches@v2.178.0-dev.1...v2.178.0-dev.2) (2023-06-16)

### Bug Fixes

* **googlerecorder/remove-device-restrictions:** add missing app constraint ([ReVanced#2438](ReVanced/revanced-patches#2438)) ([d5efe26](ReVanced/revanced-patches@939661e))
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@semantic-release-bot
chore(release): 2.178.0 [skip ci]
5a4fd6e 
# [2.178.0](ReVanced/revanced-patches@v2.177.0...v2.178.0) (2023-06-21)

### Bug Fixes

* **boostforreddit:** use correct options ([ec39732](ReVanced/revanced-patches@97930d5))
* don't include all Litho patches, when not included ([fc69491](ReVanced/revanced-patches@74caba4))
* **googlerecorder/remove-device-restrictions:** add missing app constraint ([ReVanced#2438](ReVanced/revanced-patches#2438)) ([d5efe26](ReVanced/revanced-patches@939661e))
* **youtube/comments:** add missing filter ([ReVanced#2423](ReVanced/revanced-patches#2423)) ([cab04b3](ReVanced/revanced-patches@db8843d))
* **youtube/hide-album-cards:** call correct integrations method ([0dbffaa](ReVanced/revanced-patches@2698cc4))
* **youtube:** separate `hide-ads` to `hide-layout-components` patch ([7e0417f](ReVanced/revanced-patches@81f49c2))

### Features

* **boostforreddit:** add `change-oauth-client-id` patch ([3dbc4bd](ReVanced/revanced-patches@aaf63ef))
* **google-recorder:** add `remove-device-restrictions` patch ([ef96ed1](ReVanced/revanced-patches@e3590f4))
* **twitch:** 15.4.1 support ([ReVanced#2462](ReVanced/revanced-patches#2462)) ([826ed49](ReVanced/revanced-patches@2d47db0))
* **youtube-music:** remove version compatibility constraints ([276af14](ReVanced/revanced-patches@c0b609a))
* **youtube/hide-layout-components:** separate hiding expandable chips and chapters ([3fb1ce9](ReVanced/revanced-patches@d134804))
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
@semantic-release-bot
chore(release): 2.178.0-dev.2 [skip ci]
eb908d1 
# [2.178.0-dev.2](ReVanced/revanced-patches@v2.178.0-dev.1...v2.178.0-dev.2) (2023-06-16)

### Bug Fixes

* **googlerecorder/remove-device-restrictions:** add missing app constraint ([ReVanced#2438](ReVanced/revanced-patches#2438)) ([d5efe26](ReVanced/revanced-patches@d5efe26))
tamnguyenchi93 pushed a commit to tamnguyenchi93/revanced-patches that referenced this issue Mar 24, 2024
@semantic-release-bot
chore(release): 2.178.0 [skip ci]
1686cb7 
# [2.178.0](ReVanced/revanced-patches@v2.177.0...v2.178.0) (2023-06-21)

### Bug Fixes

* **boostforreddit:** use correct options ([ec39732](ReVanced/revanced-patches@ec39732))
* don't include all Litho patches, when not included ([fc69491](ReVanced/revanced-patches@fc69491))
* **googlerecorder/remove-device-restrictions:** add missing app constraint ([ReVanced#2438](ReVanced/revanced-patches#2438)) ([d5efe26](ReVanced/revanced-patches@d5efe26))
* **youtube/comments:** add missing filter ([ReVanced#2423](ReVanced/revanced-patches#2423)) ([cab04b3](ReVanced/revanced-patches@cab04b3))
* **youtube/hide-album-cards:** call correct integrations method ([0dbffaa](ReVanced/revanced-patches@0dbffaa))
* **youtube:** separate `hide-ads` to `hide-layout-components` patch ([7e0417f](ReVanced/revanced-patches@7e0417f))

### Features

* **boostforreddit:** add `change-oauth-client-id` patch ([3dbc4bd](ReVanced/revanced-patches@3dbc4bd))
* **google-recorder:** add `remove-device-restrictions` patch ([ef96ed1](ReVanced/revanced-patches@ef96ed1))
* **twitch:** 15.4.1 support ([ReVanced#2462](ReVanced/revanced-patches#2462)) ([826ed49](ReVanced/revanced-patches@826ed49))
* **youtube-music:** remove version compatibility constraints ([276af14](ReVanced/revanced-patches@276af14))
* **youtube/hide-layout-components:** separate hiding expandable chips and chapters ([3fb1ce9](ReVanced/revanced-patches@3fb1ce9))
@Aryan-Chauhan
Copy link
Author

The wide search bar has a functional purpose unlike the header. Chose either

Still doesn't explain why cosmetic features & functional features cannot exist side-by-side.

There's no rule like that in ReVanced docs.

Waiting for member's reply.

@oSumAtrIX
Copy link
Member

They can, its simply not worth the effort. Feel free to implement the patch and pull request it

@Aryan-Chauhan Aryan-Chauhan changed the title feat (YouTube): Premium Header + Wide Search Bar appearing simultaneously. feat (YT) : Premium Header + Wide Search Bar appearing simultaneously. Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oSumAtrIX @Aryan-Chauhan