-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jimbo/uniq by #1
Jimbo/uniq by #1
Commits on Nov 11, 2020
-
[PWA-893] My Account: Order History - Remove @client directive (#2786)
* Remove client directive and work through errors from using live data * Fixup region display so its not rendering ids * Fix payment method display and remove extra comma in addresses * Additional tweaks from UX feedback * Fixup failing tests * Fix couple tests failing after gql move * Fix bug where tracking information doesn't exist for shipped order * Updated Intl FormattedMessage component mock. (#2792) * Updated FormattedMessage component mock. * div -> mock-FormattedMessage * div -> mock-FormattedMessage * Resetting price mock. * Price component snap rollback. * - Adjust item grid based on UX feedback - Add context for providing product url suffix that is missing from graphql response * Fixup failing tests * Address PR feedback * Cover new context with tests * Address QA feedback * Fixup tests and hide incomplete features * Address additional edges found in QA * Dependently render discount row * Update snaps with new mock * Allow empty string as quantity value to support backspace Co-authored-by: Revanth Kumar Annavarapu <35203638+revanth0212@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 6e6de93 - Browse repository at this point
Copy the full SHA 6e6de93View commit details -
fix: Service Worker caching for home page routes w/ store code (#2856)
* Fix regex for html file type. Previous regex matched incorrect * Use available store views in SW home route check Signed-off-by: sirugh <rugh@adobe.com> * Update tests Signed-off-by: sirugh <rugh@adobe.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for f705f28 - Browse repository at this point
Copy the full SHA f705f28View commit details
Commits on Nov 16, 2020
-
issue-2743-function-retreiveAvailableShippingMethods-spelling-change-…
… changed the function name in both the occurences (#2807) Co-authored-by: Stephen <sirugh@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 6bdbef9 - Browse repository at this point
Copy the full SHA 6bdbef9View commit details
Commits on Nov 17, 2020
-
Co-authored-by: Stephen <sirugh@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for af903b5 - Browse repository at this point
Copy the full SHA af903b5View commit details -
[docs]: Add info about RAIL model (#2761)
* Update index.md * Update pwa-devdocs/src/technologies/overview/index.md Co-authored-by: Stephen <sirugh@users.noreply.github.com> Co-authored-by: Stephen <sirugh@users.noreply.github.com> Co-authored-by: James Calcaben <jcalcaben@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b11dc6f - Browse repository at this point
Copy the full SHA b11dc6fView commit details -
[Doc] extensibility framework overview (#2863)
* Add TOC entry * Add new topic file and outline * Add how it works section * Add interceptor pattern section and image * Add content for Targets section * Add content for Intercept files * Finish Declare file content * Add content for Targets in PWA Studio packages * Add list of extension examples * Add extensibility overview diagram * Apply suggestions from code review Co-authored-by: Andy Terranova <13182778+supernova-at@users.noreply.github.com> * Fix links * Fix linting issues * Add example intercept file content Co-authored-by: Andy Terranova <13182778+supernova-at@users.noreply.github.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 20523a9 - Browse repository at this point
Copy the full SHA 20523a9View commit details
Commits on Nov 23, 2020
-
[feature]: Display "no payment method available" message if no allowe…
…d or configured payment methods are present (#2855) * Filtered payment method radios. Filtered payment method radios array because it was coming like [undefined, undefined] * Showing "No Payment method available." message Showing "No Payment method available." message when there are no supported payment methods available. * Created class to add padding to no payment method message Created class to add padding to no payment method message * Fixed formatting using prettier * Formatted with prettier * Fixed typo suggested by @sirugh * Added plain string to i18n * Added string to translations * Fixed Typo * Fixed typo * Update packages/venia-ui/lib/components/CheckoutPage/PaymentInformation/paymentMethods.js Co-authored-by: Stephen <sirugh@users.noreply.github.com> * Update packages/venia-ui/i18n/en_US.json Co-authored-by: Stephen <sirugh@users.noreply.github.com> * Fixed suggested changes given by sirugh * Added missing dep react-intl * Updated error messages and added global error color to it. * Added error test. Co-authored-by: Stephen <sirugh@users.noreply.github.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> Co-authored-by: Revanth Kumar <revanth0212@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 38bbde0 - Browse repository at this point
Copy the full SHA 38bbde0View commit details
Commits on Nov 24, 2020
-
[PWA-633] My Account: Address Book: Main View (#2857)
* Stub out address card functionality based on new mocks * - Address some missed AC and hide dead links - Cover changes in tests * Update snaps and cleanup * - Sort addresses so default comes first - Add full page loading indicator on cold cache render - Add phone number - Add full country name display * Use country data from backend until DisplayNames is more widely supported Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 6ff23a2 - Browse repository at this point
Copy the full SHA 6ff23a2View commit details
Commits on Nov 30, 2020
-
Move product detail GraphQl fields to fragment (#2868)
* move product detail graphql fields to fragment * move gql from venia-ui to peregrine * update test case
Configuration menu - View commit details
-
Copy full SHA for 2d897d7 - Browse repository at this point
Copy the full SHA 2d897d7View commit details
Commits on Dec 1, 2020
-
Use ApolloClient for MagentoRoute (#2859)
* Use Apollo for MagentoRoute * Move queries to the talon * Adjust category page loading * Refactor to avoid repeat calls * Fixup * Remove getRouteComponent * Start tests * Rewrite unit tests * Lift state up to context * @brendanfalkowski * Remove old query * Inline response objects * Update snapshots * Update category snapshots Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 97b8ced - Browse repository at this point
Copy the full SHA 97b8cedView commit details -
Fix apiBase URL in resolveUnknownRoute.js (#2877)
* Fix apiBase URL in resolveUnknownRoute.js Fix URL used by `resolveUnknownRoute.js` so it takes `apiBase` into account when constructing URL to GraphQL server * Add test for store base Signed-off-by: sirugh <rugh@adobe.com> Co-authored-by: sirugh <rugh@adobe.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for d4b853d - Browse repository at this point
Copy the full SHA d4b853dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c59de80 - Browse repository at this point
Copy the full SHA c59de80View commit details
Commits on Dec 2, 2020
-
Added feature to pick from multiple sample backends. (#2853)
* Initial work * Added magento backend validation. * Updated intercept to fetch backends. * Fetching sample backends while creating a pwa app. * Minor. * Added try catches. * Updated docs. * Minor. * Added node-fetch peer dep. * Minor pretty print stuff. * Added lodash and node-fetch deps. * Updated extension desc. * Updated tests. * Minor. * Updated remaining tests. * Added runEnvValidators.js tests. * Fixed linter issues. * Minor. * Added intercept tests. * Using debug instead of console.error. * Moving backend related code to run after configureWebpack. * Updated the skipped test. * Update ENV error reporting message. * Minor. * Minor. * Updated error snapshot test. * Minor. * Minor. * Added or condition for path variable in tests. * Minor. * Updated tests to use snapshots. * Mock everything, lets get this working. * Removed unecessary mocks. * Updated tests. * Using try catch to avoid prj creations. * Reporting different message if otherBackends is empty. * Updated tests. * Prettier fix. * Added console warning for production deployment. * Updated production launch checklist docs. Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 936bd9e - Browse repository at this point
Copy the full SHA 936bd9eView commit details -
[PWA-1128] fix(buildpack): Stop apicache from overriding good cache h…
…eaders. (#2870) * fix(buildpack): Stop apicache from overriding good cache headers. Fixes PWA-1128. * fix(venia-ui): add cache headers to upward.yml staticFromRoot resolver * fix: add simple max-age behavior to upward DirectoryResolver Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 395bbc0 - Browse repository at this point
Copy the full SHA 395bbc0View commit details
Commits on Dec 3, 2020
-
magento/magento2-page-builder/#637: Form field/field group viewport s…
…cope (#2881) - collect only desktop styles Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 6b86c6a - Browse repository at this point
Copy the full SHA 6b86c6aView commit details
Commits on Dec 4, 2020
-
[doc] update cloud deployment topic (#2871)
* Add new sections in the beginning * Revise steps and adding required extensions step * Add section about setting environment variables * Remove optional and unneeded steps * Add build, commit, and deploy sections * Add more details on finding the correct UPWARD path value * Update based on feedback * Minor content update * Changes based on review feedback * Clarify env variables section * Minor fixes Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 2e16b90 - Browse repository at this point
Copy the full SHA 2e16b90View commit details
Commits on Dec 7, 2020
-
Handle array of paths as route pattern (#2893)
* Handle array of paths as route pattern * JSON.parse route pattern when applying to Route path prop * Add tests to makeRoutesTarget
Configuration menu - View commit details
-
Copy full SHA for 18e766c - Browse repository at this point
Copy the full SHA 18e766cView commit details -
Fix missing projectConfig in create-custom-origin (#2897)
* Fix missing projectConfig in create-custom-origin * Update examples in docs Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 308e9ce - Browse repository at this point
Copy the full SHA 308e9ceView commit details
Commits on Dec 8, 2020
-
Improve RootComponents talons test coverage (#2896)
* Refactor useCategory tests * Refactor useCategory test file * Add test to useCategory.spec.js * Add location search filter test to useCategory.spec.js * Add test for error on useCategory.spec.js * Finish test coverage for useCategory * Write tests for useNoProductsFound() talon * Add tests for useCategoryContent() talon Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for c64445d - Browse repository at this point
Copy the full SHA c64445dView commit details
Commits on Dec 10, 2020
-
Address Book - Add & Edit (#2879)
* Initial layout of add / edit form * Adds unit tests * Adding address full flow. Stubs out edit address. * Country field to use country_code * Properly formats FormErrors * Absolute imports * Seeds and sets the form properly * Implements edit flow end to end * Disable dialog buttons while saving * Updates unit tests and snapshots * Implements default address checkbox * Smoothing out edges around default addresses * Attempt to fix broken test * Determinant sorting for default addresses * Update packages/venia-ui/lib/components/AddressBookPage/addressBookPage.js Co-authored-by: Jimmy Sanford <jimbo@users.noreply.github.com> * Remove auto-defaulting of addresses * Remove query result fields from add mutation * Adds query result fields to upadte mutation * Adds AddEditDialog classes to propTypes * Simplify passing parameter to edit callback function * Adds address fragments * Wait for refetchQueries to complete before finishing mutation * Waits for refetchQueries before closing dialog. Renames props. * Updates unit tests based on prop rename * Binds edit address function at creation time * Updates unit tests * Adds middle name to AddressCard display * Dialog to properly unmount on hide * Updates unit tests * Fixes new address bug * Simplifies seeding the form in useAddressBookPage talon * Adds JSDocs Co-authored-by: Jimmy Sanford <jimbo@users.noreply.github.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 60a069a - Browse repository at this point
Copy the full SHA 60a069aView commit details
Commits on Dec 14, 2020
-
[feature] Use root category id from gql (#2902)
* Use storeConfig query to obtain root category id instead of hardcoding. * Update tests * Lint Signed-off-by: sirugh <rugh@adobe.com> * Set the root category once it resolves Signed-off-by: sirugh <rugh@adobe.com> * prettier Signed-off-by: sirugh <rugh@adobe.com> * Query for root category id for fallback on cms * Protect against null id * fix tests Signed-off-by: sirugh <rugh@adobe.com> * Use id in storeConfig query Signed-off-by: sirugh <rugh@adobe.com>
Configuration menu - View commit details
-
Copy full SHA for 025cfe4 - Browse repository at this point
Copy the full SHA 025cfe4View commit details
Commits on Dec 15, 2020
-
#2797. Re-factor Edit Product to use Dialog (#2824)
* Re-factor Edit Product to use Dialog (#2797) * Re-factor Edit Product to use Dialog - CR fixes * Fixed QTY update on cart editing Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for c90caee - Browse repository at this point
Copy the full SHA c90caeeView commit details -
[PWA-458] Checkout - Sign In View (#2889)
* Remove sign-in link from CartPage * Apply new style and positioning to sign in container * - Implement view switcher similar to how the account menu works - Tweak some styles in mobile view * - Order imports consistently - Add/remove changes to language file * - Reset view state when you return to checkout - Add heading to Create Account form - Made cancel buttons low priority per UX guidance - Fixed button layout of Create Account form so it uses rows on mobile - Move SignIn container above Guest Checkout header on mobile * Update existing tests * Cover new component with tests * Add propTypes to new component * Make callback optional and remove noop function prop Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 81043d7 - Browse repository at this point
Copy the full SHA 81043d7View commit details -
Allow self signed certs for backend validation and only attach to sca…
…ffold sample (#2891) * Allow self signed certs for backend validation Signed-off-by: sirugh <rugh@adobe.com> * remove log Signed-off-by: sirugh <rugh@adobe.com> * Only copy the extension to scaffolded apps Signed-off-by: sirugh <rugh@adobe.com> * Only include sample backend validator if scaffold selection is sample Signed-off-by: sirugh <rugh@adobe.com> * Add lodash as dependency to venia-concept Signed-off-by: sirugh <rugh@adobe.com> * update lockfile Signed-off-by: sirugh <rugh@adobe.com> * Make createProjectFromVenia async Signed-off-by: sirugh <rugh@adobe.com> * Update test Signed-off-by: sirugh <rugh@adobe.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 32f5ca2 - Browse repository at this point
Copy the full SHA 32f5ca2View commit details
Commits on Dec 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 6ec0c58 - Browse repository at this point
Copy the full SHA 6ec0c58View commit details -
Add Adobe client data layer (#2852)
* Add Adobe client data layer * Clean up * Update package description Co-authored-by: deloreyj <deloreyjmi@gmail.com> * Move definition to the effect * Don't parse acdl minified code * Include react as peerDep * Bump peregrine peerdep to a caret * Revert eb59d1c Revert to tilde. Release script doesn't handle carets well, and this isn't significant. Co-authored-by: deloreyj <deloreyjmi@gmail.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com> Co-authored-by: Dev Patil <depatil@adobe.com>
Configuration menu - View commit details
-
Copy full SHA for ec4c86e - Browse repository at this point
Copy the full SHA ec4c86eView commit details
Commits on Dec 17, 2020
-
Saved payment methods main view. (#2882)
* Enabled saved payments link. * Added payment skeleton. * Moved stuff around. * Snapshot update. * Added other card types. * Cleaned up some css. * Using INTL. * Minor. * Minor css change. * Changed name of payments target to checkoutPagePaymentTypes. * Added savedPaymentTypes target. * Updated target docs. * Minor. * Hide delete text in mobile view. * Address PR feedback * Snapshot updates. * Updated snapshots. * Updated tests. * Added new tests. * Minor * Hiding delete button till PWA-638 comes in. * Added new tests. * Minor. * Rendering no payments message. * Clear CustomerPaymentTokens on signout. * Rendering fullpageindicator when data is loading. * Snapshot update. * Removing unnecessary piece of code. Co-authored-by: Tommy Wiebell <twiebell@adobe.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 5029c00 - Browse repository at this point
Copy the full SHA 5029c00View commit details
Commits on Dec 18, 2020
-
[Doc] Refactor tutorials section (#2907)
* Archive css modules topic in tutorials * Archived Using Component Props topic * Archive Manage State topic * Archive Work with GraphQL topic * Remove links to archived pages in overview topic * Archive Hello UPWARD tutorials * Various updates * Add Next Steps to project structure Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7ed1267 - Browse repository at this point
Copy the full SHA 7ed1267View commit details -
Add props to nav query to render root category links (#2911)
Signed-off-by: sirugh <rugh@adobe.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b47e582 - Browse repository at this point
Copy the full SHA b47e582View commit details
Commits on Dec 19, 2020
-
Relative import for local custom loader (#2912)
Signed-off-by: sirugh <rugh@adobe.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 548a85a - Browse repository at this point
Copy the full SHA 548a85aView commit details
Commits on Dec 22, 2020
-
Delete Address from Address Book (#2888)
* Initial delete implementation * * Binds delete function * Waits to dismiss overlay * Cancel button is low priority styled * * Stabilizes sorting * Consistent spacing between confirm buttons * Updates unit tests and snapshots * Fixes confirmation button spacing for mobile * Remove max-width on confirmation buttons * Responsive delete confirm buttons * Updates unit tests to include new output properties * Address UX feedback * Added addressCard tests. * Added addressBookPage tests. Co-authored-by: Revanth Kumar <revanth0212@gmail.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 870cb89 - Browse repository at this point
Copy the full SHA 870cb89View commit details
Commits on Dec 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ccb5e83 - Browse repository at this point
Copy the full SHA ccb5e83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3917dd8 - Browse repository at this point
Copy the full SHA 3917dd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23fd7da - Browse repository at this point
Copy the full SHA 23fd7daView commit details
Commits on Jan 4, 2021
-
Order History Page Search (#2916)
* Initial work. * Lil better with loading states. * Using debounce to fetch order number. * Re arranging useEffects. * Updated CSS. * Order search useEffect logic change. * Using onCompleted instead. * Final touchups. * Minor. * Addressed UX review. * Using submit button to search for orders. * Minor. * Minor. * Added orderHistoryPage tests. * Using fragments. * Using fuzzy search. * Added useOrderHistory tests. * Using single query for order and orders data. * Fetch all orders if search text is empty. * Allowing button submit even if the search field is empty to fetch all orders. * Test update.
Configuration menu - View commit details
-
Copy full SHA for 62429cd - Browse repository at this point
Copy the full SHA 62429cdView commit details
Commits on Jan 8, 2021
-
[PWA-887] My Account: Order History - Pagination (#2928)
* Working PoC of moving form context to just wrap search inputs * Add simple pagination logic * - Fix rendering of reset button - Add Load More button and wire up to orders query * Increase page size to UX requirement and remove unnecessary currentPage argument * Add page info label to top of page * Cover changes with tests * - Use token for font size - Make callback optional and document
Configuration menu - View commit details
-
Copy full SHA for 4d23cbb - Browse repository at this point
Copy the full SHA 4d23cbbView commit details -
[fix] offline cached search and category pages (#2929)
* Moves getPageSize query to talon default operation Signed-off-by: sirugh <rugh@adobe.com> * Only show search page error if there is no data. Signed-off-by: sirugh <rugh@adobe.com> * Only render errors when error AND no data Signed-off-by: sirugh <rugh@adobe.com> * Update tests Signed-off-by: sirugh <rugh@adobe.com> * Make sure we only do the page reset if there is no data Signed-off-by: sirugh <rugh@adobe.com> * Test page setting effect Signed-off-by: sirugh <rugh@adobe.com> Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 264baa7 - Browse repository at this point
Copy the full SHA 264baa7View commit details
Commits on Jan 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c75a3aa - Browse repository at this point
Copy the full SHA c75a3aaView commit details
Commits on Jan 20, 2021
-
[doc] release notes 9.0.0 (#2935)
* Clear out old 8.0.0 content * Add link references * Add page 1 PR entries * Add page 2 entries * Add page 3 entries * Add page 4 and 5 entries * Add details to highlights * Update compatibility table * Update highlight and known issue * Update Top Community Contributors * Update content based on feedback * Fix capitalization * Add missing entries Co-authored-by: Devagouda <40405790+dpatil-magento@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a950bfb - Browse repository at this point
Copy the full SHA a950bfbView commit details
Commits on Jan 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 26cfd49 - Browse repository at this point
Copy the full SHA 26cfd49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e9e404 - Browse repository at this point
Copy the full SHA 4e9e404View commit details
Commits on Jan 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 456b10c - Browse repository at this point
Copy the full SHA 456b10cView commit details
Commits on Jan 28, 2021
-
Add known issue about watcher running out of memory (#2977)
* Add known issue about watcher running out of memory * Add link * Update note about watcher duration
Configuration menu - View commit details
-
Copy full SHA for 64479c0 - Browse repository at this point
Copy the full SHA 64479c0View commit details
Commits on Feb 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0573cfc - Browse repository at this point
Copy the full SHA 0573cfcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66a3df8 - Browse repository at this point
Copy the full SHA 66a3df8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0fca72 - Browse repository at this point
Copy the full SHA c0fca72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33d8f4f - Browse repository at this point
Copy the full SHA 33d8f4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8769715 - Browse repository at this point
Copy the full SHA 8769715View commit details