Convert all model objects to Decodable and get rid of legacy codes
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converting `Country` model to extend Decodable protocol only. These changes only work on tvOS app only.
This new data fetching method is compatible with existing `Country` struct that only extends decodable.
Due to the usage of `Decodable` and `RevertSection` protocol on model objects, these 3 legacy protocol/strcuts are no longer needed: - `Collectable` protocol - `CollectableCollection` struct - `CollectableGroup` struct
Datasource class has been replaced.
Getting rid legacy data fetching and make use `MapLocationItem` that extends decodable.
tonyarnold
approved these changes
Aug 24, 2020
DechengMa
reviewed
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This is the continuation of PR #59.
In this PR, the legacy
DataSourceclass is replaced with the new one and all view controllers are updated to be compatible to use the newDataSourceimplementation.Therefore, all model objects needed to be converted to extend
Decodable.Other than that, all irrelevant and unused legacy codes are being removed from the project.
Changes
DataSourcereplacement.Collectable,CollectableGroup,CollectableCollection, andRequirement.Decodable.RevertItems.ItemSectionaddition to handle data inControlsViewControllerandAlertViewController.MapLocationaddition to represent each annotation fromMapLocations.plist.MapAnnotationViewinitiation and get rid of the legacy data fetching configuration.