Allow ContentDisposition to become empty #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…revent having a Content-Disposition header
notzippy
added a commit
to revel/revel.github.io
that referenced
this pull request
Feb 5, 2018
Add the revel.None for Content Disposition as for revel/revel#1300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes a ContentDisposition is not what is desired, for example if a user needs a file served with a custom name via
RenderFile(), the Name cannot be altered. Allowing to omit theContent-Dispositionheader gives the user the opportunity to do it themselves.Greetings,
Rik
PS, I see that my editor (VS Code) cleaned up the code and added some missing spaces, I hope this is not a problem for you?