Make sure the session expiration information is present in the cookie #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are adding the session expiration information to the cookie just before building the cookie, we make sure that the Expires and the information in the cookie match. In this way we do not need to resort to gymnastics to put the session expiration information in the session.
|
Looks good. Thanks! |
robfig
added a commit
that referenced
this pull request
Jun 30, 2013
Make sure the session expiration information is present in the cookie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the change that added session expiration data broke the bookings sample. If you clear your cookies and try to login, it will fail the first time, and succeed the second time. This is because the session information didn't make it to the cookie, and the session is getting cleared. Therefore the code cannot see that the user has been authenticated. At the same time, when asking the user to authenticate the second time, the TS key in the cookie is set, and the second authentication request succeeds.
With these changes the login works the first time.