Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the session expiration information is present in the cookie #201

Merged
merged 3 commits into from
Jun 30, 2013
Merged

Make sure the session expiration information is present in the cookie #201

merged 3 commits into from
Jun 30, 2013

Commits on Jun 30, 2013

  1. Use Session type to create an empty session

    @mem
    mem committed Jun 30, 2013
    Configuration menu
    Copy the full SHA
    07dfb6e View commit details
    Browse the repository at this point in the history

  2. Put cookie-formatting code in its own function

    @mem
    mem committed Jun 30, 2013
    Configuration menu
    Copy the full SHA
    416df2b View commit details
    Browse the repository at this point in the history

  3. Make sure we have an expiration time in the cookie 

    Since we are adding the session expiration information to the cookie
just before building the cookie, we make sure that the Expires and the
information in the cookie match.

In this way we do not need to resort to gymnastics to put the session
expiration information in the session.
    @mem
    mem committed Jun 30, 2013
    Configuration menu
    Copy the full SHA
    de6b442 View commit details
    Browse the repository at this point in the history