-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/domain routing #536
base: develop
Are you sure you want to change the base?
Conversation
@revel/core Do we really want Revel handling this level of HTTP? We need to decide now how deep down the rabbit hole we're going to go. If Revel doesn't offer these features, then a proxy like nginx could. We could support fcgi or some environment variable passing for things like HTTP host. Thoughts? See #549. |
@mcheng89 Sorry to be critical of this PR when I wasn't with #500, but I want to make sure this is really going to add value to Revel for more than just a few developers. Can you give some sample code demonstrating how this feature would be used given a couple example domains? How would domains be specified in the app routes and to which controllers would it be routed? Thanks. |
Besides that, I think this feature is reasonable, since it means that you don't need to run several Go processes to service a single site with multiple subdomains. |
Why is this closed @mcheng89 ? |
Anything I could do to help with getting this merged? |
Remove method from routepath and have it manually checked after route path is matched. See #1212 |
Guy what happened with this MR? |
We deferred this because we wanted to abstract the server engine, and we wanted to ensure the implementation would be backwards compatible with existing source trees. It is still open because we want to implement this at some point. |
Moved #500 to develop branch.
Todo: add reverse routing for host (in progress)