Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: Adding prefix to reverb orders #250

Closed
zztimur opened this issue May 3, 2016 · 8 comments
Closed

Q: Adding prefix to reverb orders #250

zztimur opened this issue May 3, 2016 · 8 comments

Comments

@zztimur
Copy link
Contributor

zztimur commented May 3, 2016

What do you think of adding prefix to reverb orders in magento?

@kylecrum
Copy link
Contributor

kylecrum commented May 3, 2016

Maybe? What are you thinking? Not sure of the use case here.

@zztimur
Copy link
Contributor Author

zztimur commented May 4, 2016

Example: M2E extension most popular for handling eBay and amazon sync, uses
prefixes in front of orders number.
Use case: easily distinguish sales channel - things can be handled
differently for magento sales vs external sale.

So instead of "1000049494" order would be "R-1000049494" or something like
that (for reverb).

On Tue, May 3, 2016 at 5:24 PM, Kyle Crum notifications@github.com wrote:

Maybe? What are you thinking? Not sure of the use case here.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#250 (comment)

-- Sent from my iPhone

@kylecrum
Copy link
Contributor

kylecrum commented May 4, 2016

I'll ask other shops but I don't get the sense that this is an issue with any of our current integrators.

@zztimur
Copy link
Contributor Author

zztimur commented May 4, 2016

It's not an issue, but a feature. So if I implement it, would you merge it via PR?

Also wanted to hear @dunagan5887 take on this.

@kylecrum
Copy link
Contributor

kylecrum commented May 4, 2016

That would change how all of the orders work for people who upgrade, so I'm hesitant to do so if people don't seem to want it.

@skwp
Copy link
Contributor

skwp commented May 5, 2016

If you do implement I would do so as a configuration option so it won't affect existing orders. By default there should be no prefix

Sent from my iPhone

On May 3, 2016, at 10:14 PM, Kyle Crum notifications@github.com wrote:

That would change how all of the orders work for people who upgrade, so I'm hesitant to do so if people don't seem to want it.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

@cpaterso
Copy link

Just confirming that this would be an appreciated feature! We, like many others, use M2E Pro for eBay and Amazon, and it's nice to have a custom prefix for the channel so that we can sort by channel easily in the admin panel. Obviously it could be turned on or off just like M2E, so it doesn't hurt anyone who doesn't want to use it.

@kylecrum
Copy link
Contributor

Great! We'd happily accept pull requests.

@skwp skwp closed this as completed Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants