feat: ui for field mapping #242

hvinder · 2023-09-15T11:49:37Z

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test setup

Test A
Test B

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

vercel · 2023-09-15T11:49:41Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
revert-client	❌ Failed (Inspect)			Sep 26, 2023 3:24pm

…er apis

jatinsandilya · 2023-09-25T02:52:37Z

packages/backend/helpers/redis.ts

@@ -0,0 +1,8 @@
+import { createClient } from 'redis';
+import config from '../config';
+


@hvinder lets move this out to its own folder? Perhaps backend/redis/client/index.ts

jatinsandilya · 2023-09-25T02:53:08Z

packages/backend/helpers/pubsub.ts

@@ -0,0 +1,30 @@
+import { createClient } from 'redis';
+import config from '../config';


@hvinder This could be in the same redis folder

jatinsandilya · 2023-09-25T02:55:11Z

packages/backend/helpers/authMiddleware.ts

@@ -4,7 +4,7 @@ import logError from './logError';

 const revertAuthMiddleware = () => async (req: Request, res: Response, next: () => any) => {
    const nonSecurePaths = ['/oauth-callback', '/oauth/refresh'];
-    if (nonSecurePaths.includes(req.path)) return next();
+    if (nonSecurePaths.includes(req.path) || req.path.includes('/integration-status')) return next();


@hvinder Lets move the /integration-status into the array nonSecurePaths to keep it cleaner

jatinsandilya · 2023-09-25T02:59:10Z

packages/backend/routes/v1/crm/index.ts

+    }
+});
+
+crmRouter.get('/field-mapping', revertTenantMiddleware(), async (_req, res) => {


@harvinder can we have the below endpoints via fern? or is it already?

jatinsandilya · 2023-09-26T05:05:54Z

packages/backend/helpers/tenantIdMiddleware.ts

@@ -1,9 +1,13 @@
 import { Request, Response } from 'express';
 import { xprisma } from '../prisma/client';
+// import prisma from '../prisma/client';


@hvinder Lets remove this if not being used

jatinsandilya · 2023-09-26T05:08:24Z

packages/js/src/index.ts

+                    const data = JSON.parse(event.data);
+                    const parsedData = JSON.parse(data);
+                    console.log(parsedData);
+                    // if (parsedData.status === 'FAILED') {


@hvinder Lets remove commented code unless its necessary & conveys a point.

jatinsandilya · 2023-09-26T05:08:52Z

packages/js/src/index.ts

                });
                signInElement.appendChild(button);
-                // let poweredByBanner = createPoweredByBanner(this);
+                // let poweredByBanner = createPoweredByBanner(this, true);


@hvinder Same here

* feat: processing ui * feat: immplememt sse and redis pubsub * feat: read sse data to render failed ui * minor changes * feat: api to fetch mappable details and crm object properties * feat: api to create connection field mapping * feat: add custom field mapped to connection schema * feat: reallly basic ui for std field mapping * feat: reallly basic ui for custom field mapping * feat: add styling * fix: fix add btn order * feat: check for t_id in sse msg; send private token for calling further apis * feat: save mappings on click * feat: fix ui * feat: show done screen * feat: mark form dirty if empty fields * feat: show done stage if config doesnt exist * chore: fix pr comments * chore: use temp tenant token for auth; ui fixes * chore: fix dropdown caret; redis timeout * chore: pubsub fix * chore: cleanup * chore: cleanup * chore: resolve conflicts

* prisma migration to add field mapping schemas * seed hs note model (unverified) * seed hs note model (verified) * seed hs note model * transform note acc to schema mapping * (approach 2) transform note acc to schema field mapping * (approach 2) seed all note fields and fix single note structure * minor fix * common func to transform field mapping to model * disunify using field mapping * allow connections to override field mapping * support custom objects in schema; show custom fields as additional * add winston and morgan logger * Field mapping for contact; support custom field mapping to custom crm field * add field mapping config * common unify and disunify methods * seed contact field mapping * use lodash get to transform nested mappings * unify and disunify for contact * disunify based on account config * unify and disunify for company * unify and disunify for deal * unify and disunify for event * unify and disunify for lead * unify and disunify for task * unify and disunify for user * minor refactor * handle 2 level nesting and fix mapping * make target field optional; multi level nesting * fix * fix * fix obj merge * fix pipedrive get format * preprocess * preprocess unify and disunify * disunify postprocess * flatten before disunify * pipedrive fix contact create * minor fixes * fix pipedrive lead disunify * chore: add account id to morgan logs * chore: cleanup * chore: cleanup * chore: cleanup * feat: ui for field mapping (#242) * feat: processing ui * feat: immplememt sse and redis pubsub * feat: read sse data to render failed ui * minor changes * feat: api to fetch mappable details and crm object properties * feat: api to create connection field mapping * feat: add custom field mapped to connection schema * feat: reallly basic ui for std field mapping * feat: reallly basic ui for custom field mapping * feat: add styling * fix: fix add btn order * feat: check for t_id in sse msg; send private token for calling further apis * feat: save mappings on click * feat: fix ui * feat: show done screen * feat: mark form dirty if empty fields * feat: show done stage if config doesnt exist * chore: fix pr comments * chore: use temp tenant token for auth; ui fixes * chore: fix dropdown caret; redis timeout * chore: pubsub fix * chore: cleanup * chore: cleanup * chore: resolve conflicts * feat: add remove mapping btn and divider * fix: fix logger * chore: cleanup * chore: move endpoints to fern * update yarn.lock * fix issues * add hubspot create custom properties api --------- Co-authored-by: jatin <sandilya.jatin@gmail.com>

* prisma migration to add field mapping schemas * seed hs note model (unverified) * seed hs note model (verified) * seed hs note model * transform note acc to schema mapping * (approach 2) transform note acc to schema field mapping * (approach 2) seed all note fields and fix single note structure * minor fix * common func to transform field mapping to model * disunify using field mapping * allow connections to override field mapping * support custom objects in schema; show custom fields as additional * add winston and morgan logger * Field mapping for contact; support custom field mapping to custom crm field * add field mapping config * common unify and disunify methods * seed contact field mapping * use lodash get to transform nested mappings * unify and disunify for contact * disunify based on account config * unify and disunify for company * unify and disunify for deal * unify and disunify for event * unify and disunify for lead * unify and disunify for task * unify and disunify for user * minor refactor * handle 2 level nesting and fix mapping * make target field optional; multi level nesting * fix * fix * fix obj merge * fix pipedrive get format * preprocess * preprocess unify and disunify * disunify postprocess * flatten before disunify * pipedrive fix contact create * minor fixes * fix pipedrive lead disunify * chore: add account id to morgan logs * chore: cleanup * chore: cleanup * chore: cleanup * feat: ui for field mapping (revertinc#242) * feat: processing ui * feat: immplememt sse and redis pubsub * feat: read sse data to render failed ui * minor changes * feat: api to fetch mappable details and crm object properties * feat: api to create connection field mapping * feat: add custom field mapped to connection schema * feat: reallly basic ui for std field mapping * feat: reallly basic ui for custom field mapping * feat: add styling * fix: fix add btn order * feat: check for t_id in sse msg; send private token for calling further apis * feat: save mappings on click * feat: fix ui * feat: show done screen * feat: mark form dirty if empty fields * feat: show done stage if config doesnt exist * chore: fix pr comments * chore: use temp tenant token for auth; ui fixes * chore: fix dropdown caret; redis timeout * chore: pubsub fix * chore: cleanup * chore: cleanup * chore: resolve conflicts * feat: add remove mapping btn and divider * fix: fix logger * chore: cleanup * chore: move endpoints to fern * update yarn.lock * fix issues * add hubspot create custom properties api --------- Co-authored-by: jatin <sandilya.jatin@gmail.com>

hvinder added 3 commits September 14, 2023 12:31

feat: processing ui

2660cd0

feat: immplememt sse and redis pubsub

900f907

feat: read sse data to render failed ui

7dc356a

vercel bot deployed to Preview September 15, 2023 11:51 View deployment

hvinder self-assigned this Sep 15, 2023

hvinder marked this pull request as draft September 15, 2023 11:52

hvinder added feature api UI labels Sep 15, 2023

hvinder added 2 commits September 18, 2023 22:45

minor changes

711f120

feat: api to fetch mappable details and crm object properties

b1276b2

vercel bot deployed to Preview September 19, 2023 13:42 View deployment

hvinder added 2 commits September 19, 2023 19:29

feat: api to create connection field mapping

5b38dad

feat: add custom field mapped to connection schema

cd4f573

vercel bot deployed to Preview September 20, 2023 08:38 View deployment

hvinder added 10 commits September 20, 2023 23:01

feat: reallly basic ui for std field mapping

773a658

feat: reallly basic ui for custom field mapping

5dd50e5

feat: add styling

7d91ea3

fix: fix add btn order

561a552

feat: check for t_id in sse msg; send private token for calling furth…

b7c7c34

…er apis

feat: save mappings on click

bd18e5d

feat: fix ui

540c8ad

feat: show done screen

b3680d0

feat: mark form dirty if empty fields

223dfc5

feat: show done stage if config doesnt exist

3a6fbb9

vercel bot deployed to Preview September 22, 2023 08:33 View deployment

hvinder marked this pull request as ready for review September 22, 2023 17:42

jatinsandilya reviewed Sep 25, 2023

View reviewed changes

hvinder added 2 commits September 25, 2023 13:24

chore: fix pr comments

9d7a827

chore: use temp tenant token for auth; ui fixes

b1fce42

vercel bot deployed to Preview September 25, 2023 11:20 View deployment

chore: fix dropdown caret; redis timeout

5ed54f5

vercel bot deployed to Preview September 25, 2023 12:11 View deployment

chore: pubsub fix

431c235

jatinsandilya reviewed Sep 26, 2023

View reviewed changes

hvinder added 3 commits September 26, 2023 18:25

chore: cleanup

9799cd4

chore: cleanup

c31782d

chore: resolve conflicts

f84be6c

vercel bot had a problem deploying to Preview September 26, 2023 14:04 Failure

chore: resolve conflicts

2bc1831

vercel bot had a problem deploying to Preview September 26, 2023 15:24 Failure

hvinder merged commit fae50c4 into feat/field-mapping Sep 27, 2023
1 of 2 checks passed

jatinsandilya deleted the feat/ui-for-field=mapping branch March 26, 2024 16:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ui for field mapping #242

feat: ui for field mapping #242

hvinder commented Sep 15, 2023

vercel bot commented Sep 15, 2023 •

edited

Loading

jatinsandilya Sep 25, 2023

jatinsandilya Sep 25, 2023

jatinsandilya Sep 25, 2023

jatinsandilya Sep 25, 2023

jatinsandilya Sep 26, 2023

jatinsandilya Sep 26, 2023

jatinsandilya Sep 26, 2023

		@@ -0,0 +1,8 @@
		import { createClient } from 'redis';
		import config from '../config';

		@@ -0,0 +1,30 @@
		import { createClient } from 'redis';
		import config from '../config';

feat: ui for field mapping #242

feat: ui for field mapping #242

Conversation

hvinder commented Sep 15, 2023

Description

Type of change

How Has This Been Tested?

Checklist:

vercel bot commented Sep 15, 2023 • edited Loading

jatinsandilya Sep 25, 2023

Choose a reason for hiding this comment

jatinsandilya Sep 25, 2023

Choose a reason for hiding this comment

jatinsandilya Sep 25, 2023

Choose a reason for hiding this comment

jatinsandilya Sep 25, 2023

Choose a reason for hiding this comment

jatinsandilya Sep 26, 2023

Choose a reason for hiding this comment

jatinsandilya Sep 26, 2023

Choose a reason for hiding this comment

jatinsandilya Sep 26, 2023

Choose a reason for hiding this comment

vercel bot commented Sep 15, 2023 •

edited

Loading