Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement close crm integration #364

Merged
merged 20 commits into from
Nov 21, 2023
Merged

feat: implement close crm integration #364

merged 20 commits into from
Nov 21, 2023

Conversation

ashutoshdhande
Copy link
Contributor

@ashutoshdhande ashutoshdhande commented Nov 15, 2023 •
edited by jatinsandilya

Description

This Pull Request includes the implementation of all contact service endpoints and oauth for closecrm.

Closes #60

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Via Postman

Checkout these demos

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas

ashutoshdhande and others added 8 commits October 24, 2023 17:23
@ashutoshdhande
feat(close-crm-integration): implement OAuth integration and generate…
576d653 
… refresh token
@ashutoshdhande
last day at HOME
198dcc3
@ashutoshdhande
feat(contact): implement CRUD operations
f3c5604 
- Added endpoints for creating, reading, updating, and deleting contacts.
- Completed integration for all contact-related functionalities.
@ashutosh-revert
feat(contact-service): implement pagination in getContacts
bc2309b
@ashutosh-revert
fix(contact-service): resolve NaN issue in pagination for getContacts
c928652 
The previous implementation of pagination in the getContacts method was displaying NaN values when all items were fetched. This commit addresses the issue by ensuring proper handling when determining the next skip value.
@ashutosh-revert
fix(contact-service): resolve name issue for closecrm
03817fe
@ashutosh-revert
feat(contact-service): Implementation of update contact in close crm
1066484
@ashutosh-revert
feat(contact-service): Implement search endpoint and fix name field i…
8eb5bcd 
…ssue in Close CRM
@vercel Vercel
Copy link

vercel bot commented Nov 15, 2023

@ashutosh-revert is attempting to deploy a commit to the Revertdev Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited

Thank you for following the naming conventions for pull request titles! 🙏

@ashutoshdhande ashutoshdhande changed the title Close crm integration feat: Implement OAuth and Contact Service integration[MINOR] Nov 15, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 15, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
revert-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 10:28am

@jatinsandilya jatinsandilya changed the title feat: Implement OAuth and Contact Service integration[MINOR] feat: Implement Close CRM Integration Nov 20, 2023
@jatinsandilya jatinsandilya changed the title feat: Implement Close CRM Integration feat: implement close crm integration Nov 20, 2023
jatinsandilya
jatinsandilya requested changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@jatinsandilya jatinsandilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments for the changes needed

packages/backend/index.ts Outdated Show resolved Hide resolved
packages/client/src/data/hooks/index.ts Outdated Show resolved Hide resolved
packages/react/src/App.tsx Outdated Show resolved Hide resolved
packages/backend/routes/v1/crm/auth.ts Outdated Show resolved Hide resolved
packages/backend/services/metadata.ts Show resolved Hide resolved
packages/backend/helpers/crm/transform/preprocess.ts Outdated Show resolved Hide resolved
jatinsandilya
jatinsandilya approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@jatinsandilya jatinsandilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@jatinsandilya jatinsandilya merged commit b660766 into revertinc:main Nov 21, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jatinsandilya jatinsandilya jatinsandilya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Close.io CRM Support
3 participants
@ashutoshdhande @jatinsandilya @ashutosh-revert