-
-
Notifications
You must be signed in to change notification settings - Fork 74
Conversation
@manish-singh-bisht is attempting to deploy a commit to the OpenInt Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions for pull request titles! 🙏 |
…tion for github,and other needed for the previous.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
things to change
github.mdx, packages/client/src/features/integration/enums/metadata.ts, packages/backend/services/metadata.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manish-singh-bisht added some comments can you have a look, ping me here once you have done.
also have you tested this integration for customRedirectUrls ? if not please do and lemme know if that works or not this one: https://github.com/revertinc/revert/pull/574/files
integrationId: TP_ID.github, | ||
name: 'GitHub', | ||
imageSrc: | ||
'https://res.cloudinary.com/dfcnic8wq/image/upload/v1702983006/Revert/szfzkoagws7h3miptezo.png', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is image of Jira
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes this jatin will provide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
github: { | ||
name: 'GitHub', | ||
logo: 'https://res.cloudinary.com/dfcnic8wq/image/upload/v1711549311/Revert/cmqpors8m8tid9zpn9ak.png', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logo: 'https://res.cloudinary.com/dfcnic8wq/image/upload/v1711549311/Revert/cmqpors8m8tid9zpn9ak.png', | |
logo: GITHUBLOGO, |
works |
integrationId: TP_ID.github, | ||
name: 'GitHub', | ||
imageSrc: | ||
'https://res.cloudinary.com/dfcnic8wq/image/upload/v1702983006/Revert/szfzkoagws7h3miptezo.png', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nabhag8848 we need images for the above mentioned places.thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manish-singh-bisht LGTM
Description
Fixes #252
added github issue integration
task,user,collections,comments endpoints added
oauth added
https://www.loom.com/share/8404afa6be614e098a02268a3b5b88a1 (users,tasks,collections,comment(create,update,getComment))
https://www.loom.com/share/2d0ee45aae304e11baea2378253d62f3 (comment-get comments- 8 May 2024)
Type of change
How Has This Been Tested?
postman
Checklist: