Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Consolidate some of the examples in one screen #280

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jeremyscatigna
Copy link

first part of the implementation still WIP, trying to implement both button and input examples

@OhadRau
Copy link
Collaborator

OhadRau commented Jan 31, 2019

@jeremyscatigna Looks like the CI never triggered. Maybe try merging in master and pushing again? Usually another push will get it to work.

@bryphe
Copy link
Member

bryphe commented Feb 8, 2019

Just tried this out and its looking great, @jeremyscatigna ! Thank you for your work on this (and sorry I was so delayed in reviewing it).

There's only tweak - I wonder if we could center the example vertically / horizontally? Would help for our web playground!

Was there anything else that was top of mind for you?

Let me know if you need help with the merge or wrapping this up - having these elements consolidated is a big improvement! 👍

@jeremyscatigna
Copy link
Author

Thanks @bryphe ! Almost finished need to clean the layout a bit and all that fill in properly, will center the example and let you know when good.

Would love help to merge when everythings good 💪

@albertorestifo
Copy link

Related to #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants