-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples: Analog Clock Example #310
Conversation
top(75), | ||
backgroundColor(Colors.red), | ||
transform([ | ||
Transform.Rotate(Angle.from_degrees(secondDegrees)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! π―
Just tried it out locally, looks great @lessp ! Thanks for the example π Nice use of the Timer + Transforms to bring this together! |
esy.lock/index.json
Outdated
"node": { | ||
"revery@link:./package.json": { | ||
"id": "revery@link:./package.json", | ||
"revery@link-dev:./package.json": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link-dev
is problematic for my esy build (0.4.9
) - I wonder if we need the lockfile change for this? I suspect this will also cause the CI build to fail. Here's the build output I saw when I ran esy install
:
info install 0.4.9 (using package.json)
error: corrupted esy.lock lock
you might want to remove it and install from scratch
error: error: unknown source type: link-dev
reading lock D:\revery\esy.lock
esy: exiting due to errors above
(I had to delete the lockfile to get the PR to install w/ esy@0.4.9)
Just curious - which esy
version are you using, @lessp ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example looks great! The only blocker I see is fixing the lockfile build issue (one option would be to revert the lockfile commit for now - and we could track upgrading esy on our CI machines in a separate issue/PR).
Sweet! Looks like I forgot to push the latest changes (visual), so I did that too. Should work, hopefully! π -- Looks like I'm using esy EDIT: Sorry, that didn't work. Will fix in a bit! |
This reverts commit f5aedce.
b5aa7ef
to
618a42c
Compare
Mostly to get the CI to build again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the lockfile issues, @lessp ! Latest changes look great π
Green CI - looks great π Thanks again for all the work on this, @lessp ! Bringing it in now. |
* docs: Initial work on Clock * chore: lock-files * docs(examples): change name, some cleanup for AnalogClock * docs(example): Add border to Clock-container * chore(revert): revert lock-files This reverts commit f5aedce. * chore: replace package-files with files from master * chore: remove conflicting yojson-file * style: sort properties alphabetically Mostly to get the CI to build again * style: add newlines for build to pass
Hey all!
I took a stab at creating an Example Clock, I'm still very new to Revery and the Reason-world so any improvements are most welcome, of course! π
The mov to gif-conversion seems to have left some second ticks behind! π€·ββοΈ
Closes #41