Patch by Dana Lacoste to fix a bug with post-review on Windows where we

improperly check for the os.uname function. Fixes bug #1280.
reviewboard · Aug 22, 2009 · 6cc7f94 · 6cc7f94
1 parent 30c11fc
commit 6cc7f94
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/AUTHORS b/AUTHORS
@@ -7,6 +7,7 @@ Lead Developers:
 Contributors:
 
 	* Chris Clark
+	* Dana Lacoste
 	* Eric Huss
 	* Jeremy Bettis
 	* Lepton Wu

diff --git a/rbtools/postreview.py b/rbtools/postreview.py
@@ -1629,7 +1629,7 @@ def _do_diff(self, old_file, new_file, depot_path, base_revision,
 
         Returns a list of strings of diff lines.
         """
-        if os.uname and os.uname()[0] == 'SunOS':
+        if hasattr(os, 'uname') and os.uname()[0] == 'SunOS':
             diff_cmd = ["gdiff", "-urNp", old_file, new_file]
         else:
             diff_cmd = ["diff", "-urNp", old_file, new_file]