Skip to content

Commit

Permalink
Patch by Raghu Kaippully to fix changesets with binary files in Perfo…
Browse files Browse the repository at this point in the history
…rce when using post-review.

Reviewed at http://reviews.review-board.org/r/787/
Fixes bug #585
  • Loading branch information
chipx86 committed Mar 27, 2009
1 parent f5ec35f commit 6d7e0fe
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
5 changes: 5 additions & 0 deletions AUTHORS
Expand Up @@ -2,3 +2,8 @@ Lead Developers:

* Christian Hammond
* David Trowbridge


Contributors:

* Raghu Kaippully
3 changes: 2 additions & 1 deletion scripts/post-review
Expand Up @@ -1455,7 +1455,8 @@ class PerforceClient(SCMClient):
# and the code below expects the outptu to start with
# "Binary files "
if len(dl) == 1 and \
dl[0] == ('Files %s and %s differ'% (old_file, new_file)):
dl[0].startswith('Files %s and %s differ' %
(old_file, new_file)):
dl = ['Binary files %s and %s differ'% (old_file, new_file)]

if dl == [] or dl[0].startswith("Binary files "):
Expand Down

0 comments on commit 6d7e0fe

Please sign in to comment.