Skip to content

Commit

Permalink
Fix an early return when using a server with the deprecated API.
Browse files Browse the repository at this point in the history
When using the deprecated API, check_api_version() bails too early. This
seems okay in real use, but breaks in unit tests. Now it continues on.
  • Loading branch information
chipx86 committed Feb 27, 2012
1 parent adda2b2 commit e5515e3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion rbtools/postreview.py
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ def check_api_version(self):
# done your http basic auth
die("Unable to access the root /api/ URL on the server.")

return False
return False

# This is an older Review Board server with the old API.
self.deprecated_api = True
Expand Down
1 change: 1 addition & 0 deletions rbtools/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ def __init__(self):
self.username = None
self.password = None
self.repository_url = None
self.disable_proxy = False


class ApiTests(MockHttpUnitTest):
Expand Down

0 comments on commit e5515e3

Please sign in to comment.