Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example and reviewdog.yml #30

Merged
merged 3 commits into from
Feb 13, 2021

Conversation

tsuyoshicho
Copy link
Contributor

@tsuyoshicho tsuyoshicho commented Feb 11, 2021

example update

Use github.workflow , steps.depup.outputs.repo for Pull-request message.
This copy to use generically.

depup.yml update

Update above change.

Copy link
Member

@haya14busa haya14busa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using steps.depup.outputs.repo instead of github.job?

@tsuyoshicho
Copy link
Contributor Author

tsuyoshicho commented Feb 11, 2021

How about using steps.depup.outputs.repo instead of github.job?

I think to keep the characteristics of the old format.
update it.

# change reviewdog -> reviewdog/reviewdog

Copy link
Member

@haya14busa haya14busa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@haya14busa haya14busa merged commit 5d9f292 into reviewdog:master Feb 13, 2021
@tsuyoshicho tsuyoshicho deleted the fix/exampleupdate-20210211 branch February 13, 2021 23:35
haya14busa added a commit that referenced this pull request Feb 21, 2021
It's removed by #30, but it's required, at least for depup testing which
uses multiple branches to run depup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants