Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tflint Target Directory Parameter #59

Merged
merged 3 commits into from
Oct 29, 2022

Conversation

jw-maynard
Copy link
Contributor

Hey @Vlaaaaaaad and @haya14busa I want to add this additional parameter. For my user case I would like to have one .tflint.hcl file in the root of my repo but use that same configuration to check multiple sub directories in the repo. Currently working_directory doesn't work easily for this use case because tflint seems to look in the working directory for it's config and it would be harder to change the working dir and then use a flag to point back to the config in the repo root than to just run tflint from the root and point it to the sub module dirs.

Thanks.

@jw-maynard
Copy link
Contributor Author

jw-maynard commented Oct 28, 2022

@shogo82148 Any chance you could review and merge this or suggest changes?

Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shogo82148 shogo82148 merged commit 9a32252 into master Oct 29, 2022
@shogo82148 shogo82148 deleted the feature/add-tflint-dir-param branch October 29, 2022 23:40
@jw-maynard
Copy link
Contributor Author

@shogo82148 sorry to bother you. Can you make a release? It looks like a tag needs to be pushed to master and I can't do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants