Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tflint deprecation #70

Merged
merged 2 commits into from
May 19, 2023

Conversation

c0nn0rstevens
Copy link
Contributor

This PR aims to fix the use of deprecated tflint cli syntax which was causing our CI pipeline to fail when using this action.
Screenshot 2023-05-16 at 15 38 24

@Sebelino
Copy link

Looks like the check fails because of this line:

tflint_version: v0.32.0

The -chdir parameter was not present in that old version of tflint. You can fix the error by setting this value to 0.46.1. Or remove the line entirely.

@c0nn0rstevens
Copy link
Contributor Author

c0nn0rstevens commented May 17, 2023

Thanks for the pointer! Will add it and push the change. Removing it would default to 'latest', right?

@Sebelino
Copy link

Looks that way:

default: 'latest'

Copy link

@Sebelino Sebelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sebelino Sebelino merged commit 578520c into reviewdog:master May 19, 2023
11 checks passed
@review-dog
Copy link
Member

Hi, @c0nn0rstevens! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants