Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only specify Chdir command if it is needed #73

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Only specify Chdir command if it is needed #73

merged 1 commit into from
Jun 16, 2023

Conversation

mitchellharvey97
Copy link
Contributor

Hey, this is a proposed PR to fix #72

I can update the documentation etc to match the change but just wanted to confirm that this is the best way to achieve this fix before writing the documentation etc for it

script.sh Outdated Show resolved Hide resolved
script.sh Outdated Show resolved Hide resolved
script.sh Outdated Show resolved Hide resolved
script.sh Show resolved Hide resolved
@mitchellharvey97
Copy link
Contributor Author

@Sebelino thankyou for your review. I have made the above changes

script.sh Outdated Show resolved Hide resolved
Copy link

@Sebelino Sebelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sebelino Sebelino merged commit 4445f62 into reviewdog:master Jun 16, 2023
11 checks passed
@review-dog
Copy link
Member

Hi, @mitchellharvey97! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintenance of reviewdog.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support --recursive flag
3 participants