strict check of pr-review write permission #1521
Conversation
There is currently no way to check the available scope of the tokens provided by GitHub; the tokens available for GitHub Actions vary in permissions in complex ways, depending on the repository, workflow settings, and how the workflow is launched. The most reliable way is to actually post review comments.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Is this pr review ready? |
|
No, I doesn't work expectly... |
it doesn't work with reviewdog-pr.
|
@haya14busa it's ready, can you review it please. |
service/github/github_test.go
Outdated
| InDiffFile: true, | ||
| InDiffContext: true, | ||
| }, | ||
| ToolName: "tool", |
There was a problem hiding this comment.
Can we use a bit more helpful tool name and message?
e.g. tool name: service/github/github_test.go
message: test message for TestGitHubPullRequest_Post_NoPermission
service/github/github_test.go
Outdated
| Result: &filter.FilteredDiagnostic{ | ||
| Diagnostic: &rdf.Diagnostic{ | ||
| Location: &rdf.Location{ | ||
| Path: "reviewdog.go", |
There was a problem hiding this comment.
Can we use a file under _testdata/ file or service/github/github_test.go if this test expect outputting the actual github action log comments?
| continue | ||
| } | ||
|
|
||
| rawComments = append(rawComments, c) | ||
| if !c.Result.InDiffContext { | ||
| // If the result is outside of diff context, fallback to GitHub Review | ||
| // Comment API. | ||
| comment := buildPullRequestComment(c, body, g.sha) |
There was a problem hiding this comment.
[Unrelated to this pr]
I noticed that line (position) information is completely lost for these file comments and it must be confusing for most cases. 🤔
Probably we should add line (position) information in comment body.
(You don't need to address this comment in this pr. )
TestGitHubPullRequest_Post_NoPermission
|
@haya14busa I'm glad the alternative way was found and merged. (Though, it's a bit sad that the PR #1406 was closed without any interaction after a long pending time) |
There is currently no way to check the available scope of the tokens provided by GitHub; the tokens available for GitHub Actions vary in permissions in complex ways, depending on the repository, workflow settings, and how the workflow is launched.
The most reliable way is to actually post review comments.
close #1210