Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constants for http methods instead of strings #212

Merged
merged 1 commit into from
Mar 31, 2019
Merged

Use constants for http methods instead of strings #212

merged 1 commit into from
Mar 31, 2019

Conversation

mgrachev
Copy link
Member

No description provided.

shogo82148
shogo82148 approved these changes Mar 31, 2019
View reviewed changes
Copy link
Contributor

@shogo82148 shogo82148 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haya14busa haya14busa merged commit 8276e49 into reviewdog:master Mar 31, 2019
@mgrachev mgrachev deleted the feature/http-refactoring branch March 31, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shogo82148 shogo82148 shogo82148 approved these changes

@haya14busa haya14busa haya14busa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgrachev @shogo82148 @haya14busa