Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constants for http methods instead of strings #212

Merged
merged 1 commit into from Mar 31, 2019

Conversation

Projects
None yet
3 participants
@mgrachev
Copy link
Member

mgrachev commented Mar 30, 2019

No description provided.

@shogo82148
Copy link
Contributor

shogo82148 left a comment

LGTM

@haya14busa haya14busa merged commit 8276e49 into reviewdog:master Mar 31, 2019

5 checks passed

ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 42.85% of diff hit (target 0%)
Details
codecov/project 53.33% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mgrachev mgrachev deleted the mgrachev:feature/http-refactoring branch Mar 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.