Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constants for http methods instead of strings #212

Merged
merged 1 commit into from Mar 31, 2019
Merged

Use constants for http methods instead of strings #212

merged 1 commit into from Mar 31, 2019

Conversation

@mgrachev
Copy link
Member

@mgrachev mgrachev commented Mar 30, 2019

No description provided.

Copy link
Contributor

@shogo82148 shogo82148 left a comment

LGTM

@haya14busa haya14busa merged commit 8276e49 into reviewdog:master Mar 31, 2019
16 checks passed
16 checks passed
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
@codecov
codecov/patch 42.85% of diff hit (target 0%)
Details
@codecov
codecov/project 53.33% (target 0%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@reviewdog
errcheck reviewdog [errcheck] report
Details
@reviewdog
golangci reviewdog [golangci] report
Details
@reviewdog
golint reviewdog [golint] report
Details
@reviewdog
gosimple reviewdog [gosimple] report
Details
@reviewdog
govet reviewdog [govet] report
Details
@reviewdog
misspell reviewdog [misspell] report
Details
@reviewdog
revive reviewdog [revive] report
Details
@reviewdog
staticcheck reviewdog [staticcheck] report
Details
@reviewdog
textlint reviewdog [textlint] report
Details
@reviewdog
unparam reviewdog [unparam] report
Details
@reviewdog
unused reviewdog [unused] report
Details
@mgrachev mgrachev deleted the mgrachev:feature/http-refactoring branch Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants